You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by "yaalsn (via GitHub)" <gi...@apache.org> on 2024/05/11 08:45:51 UTC
[PR] Skip mount command error [bookkeeper]
yaalsn opened a new pull request, #4360:
URL: https://github.com/apache/bookkeeper/pull/4360
### Motivation
Fix
### Changes
(Describe: what changes you have made)
> ---
> In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
> checks for pull requests. A pull request can only be merged when it passes precommit checks.
>
> ---
> Be sure to do all the following to help us incorporate your contribution
> quickly and easily:
>
> If this PR is a BookKeeper Proposal (BP):
>
> - [ ] Make sure the PR title is formatted like:
> `<BP-#>: Description of bookkeeper proposal`
> `e.g. BP-1: 64 bits ledger is support`
> - [ ] Attach the master issue link in the description of this PR.
> - [ ] Attach the google doc link if the BP is written in Google Doc.
>
> Otherwise:
>
> - [ ] Make sure the PR title is formatted like:
> `<Issue #>: Description of pull request`
> `e.g. Issue 123: Description ...`
> - [ ] Make sure tests pass via `mvn clean apache-rat:check install spotbugs:check`.
> - [ ] Replace `<Issue #>` in the title with the actual Issue number.
>
> ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ci] Skip mount command error when tune runner vm [bookkeeper]
Posted by "yaalsn (via GitHub)" <gi...@apache.org>.
yaalsn commented on PR #4360:
URL: https://github.com/apache/bookkeeper/pull/4360#issuecomment-2105643890
> Looks good, I think we should edit the commit message and title related to ci, otherwise it looks scary
Thanks for your advice, updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ci] Skip mount command error when tune runner vm [bookkeeper]
Posted by "shoothzj (via GitHub)" <gi...@apache.org>.
shoothzj commented on PR #4360:
URL: https://github.com/apache/bookkeeper/pull/4360#issuecomment-2105672046
@yaalsn I appreciate your effort in modifying the PR title. However, it would be helpful to also update the commit message to ensure consistency when it merges. Let's aim to refine this process for next time. Thank you for your understanding. :)
cc @hangc0276
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ci] Skip mount command error when tune runner vm [bookkeeper]
Posted by "hangc0276 (via GitHub)" <gi...@apache.org>.
hangc0276 merged PR #4360:
URL: https://github.com/apache/bookkeeper/pull/4360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org