You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "pierrejeambrun (via GitHub)" <gi...@apache.org> on 2025/04/18 21:35:56 UTC
[PR] Fix connection form meta when fab provider is missing [airflow]
pierrejeambrun opened a new pull request, #49446:
URL: https://github.com/apache/airflow/pull/49446
We are trying to patch modules that aren't there in the first place. This can happen if `fab` provider is not installed.
To reproduce, just go into `airflow-core`, `uv sync --no-dev` (fab provider should not be there), then go to the connection page in the UI.
To be honest this might be enough to cancel rc3 as connection page in the UI will be broken for anybody that do not have the fab-provider installed.
## Before
<img width="1493" alt="Screenshot 2025-04-18 at 23 35 38" src="https://github.com/user-attachments/assets/b06504c9-060a-4da6-927c-df8150a7df90" />
<img width="1499" alt="Screenshot 2025-04-18 at 23 35 19" src="https://github.com/user-attachments/assets/f6b14f53-b80c-47e1-9476-c27d55e1ad6b" />
## After
<img width="1508" alt="Screenshot 2025-04-18 at 23 34 26" src="https://github.com/user-attachments/assets/72a75381-794a-450b-8328-8b25943cd69a" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix connection form meta when fab provider is missing [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #49446:
URL: https://github.com/apache/airflow/pull/49446#issuecomment-2816288516
Args, with the mocking I added the target was actually to be independent of FAB. But at time of implementation FAB still was mandatory... so maybe this had not been tested sufficiently... sorry.
I am still on the move, will be home by tomorrow evening. Earliest Sunday I'm able to really review and understand. WHat is the outcome if the exception is catched because dependencies are missing? Will just be no element displayed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix connection form meta when fab provider is missing [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #49446:
URL: https://github.com/apache/airflow/pull/49446#issuecomment-2816232871
cc: @ephraimbuddy @dstandish @jscheffl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix connection form meta when fab provider is missing [airflow]
Posted by "ashb (via GitHub)" <gi...@apache.org>.
ashb merged PR #49446:
URL: https://github.com/apache/airflow/pull/49446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix connection form meta when fab provider is missing [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #49446:
URL: https://github.com/apache/airflow/pull/49446#issuecomment-2816544814
> What is the outcome if the exception is catched because dependencies are missing? Will just be no element displayed?
As I understand if the element is missing (module not installed) it means that no provider depends on fab provider, which means that no `get_connection_from_widgets` depends on it (for instance wtform widgets). Therefore yes the widged will not be there, but no connection form acatually use it, so it shouldn't cause trouble, to my understanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix connection form meta when fab provider is missing [airflow]
Posted by "dstandish (via GitHub)" <gi...@apache.org>.
dstandish commented on PR #49446:
URL: https://github.com/apache/airflow/pull/49446#issuecomment-2816306204
Here's an alternative that just rips out the mocking. Seems to work with my local testing.
https://github.com/apache/airflow/pull/49448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix connection form meta when fab provider is missing [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #49446:
URL: https://github.com/apache/airflow/pull/49446#issuecomment-2816802023
Thanks for the fix! I am very Sorry this caused RC4 :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org