You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by si...@apache.org on 2016/12/21 18:40:31 UTC
bookkeeper git commit: BOOKKEEPER-964: Ignore findbugs warnings
Repository: bookkeeper
Updated Branches:
refs/heads/master 6e738d0c0 -> f53cbf827
BOOKKEEPER-964: Ignore findbugs warnings
Author: eolivelli <eo...@gmail.com>
Reviewers: Sijie Guo <si...@apache.org>
Closes #96 from eolivelli/BOOKKEEPER-964-findbugs
Project: http://git-wip-us.apache.org/repos/asf/bookkeeper/repo
Commit: http://git-wip-us.apache.org/repos/asf/bookkeeper/commit/f53cbf82
Tree: http://git-wip-us.apache.org/repos/asf/bookkeeper/tree/f53cbf82
Diff: http://git-wip-us.apache.org/repos/asf/bookkeeper/diff/f53cbf82
Branch: refs/heads/master
Commit: f53cbf82758af7f620ecd1506c76801bd0e75c86
Parents: 6e738d0
Author: eolivelli <eo...@gmail.com>
Authored: Wed Dec 21 10:40:28 2016 -0800
Committer: Sijie Guo <si...@apache.org>
Committed: Wed Dec 21 10:40:28 2016 -0800
----------------------------------------------------------------------
.../src/main/java/org/apache/bookkeeper/proto/BookieServer.java | 3 +--
bookkeeper-server/src/main/resources/findbugsExclude.xml | 4 ++++
2 files changed, 5 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/bookkeeper/blob/f53cbf82/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
----------------------------------------------------------------------
diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
index 461f347..14350e6 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/BookieServer.java
@@ -325,8 +325,7 @@ public class BookieServer {
throw new IllegalArgumentException();
}
- ServerConfiguration conf = new ServerConfiguration();
- String[] leftArgs = cmdLine.getArgs();
+ ServerConfiguration conf = new ServerConfiguration();
if (cmdLine.hasOption('c')) {
String confFile = cmdLine.getOptionValue("c");
http://git-wip-us.apache.org/repos/asf/bookkeeper/blob/f53cbf82/bookkeeper-server/src/main/resources/findbugsExclude.xml
----------------------------------------------------------------------
diff --git a/bookkeeper-server/src/main/resources/findbugsExclude.xml b/bookkeeper-server/src/main/resources/findbugsExclude.xml
index bff9431..fa94708 100644
--- a/bookkeeper-server/src/main/resources/findbugsExclude.xml
+++ b/bookkeeper-server/src/main/resources/findbugsExclude.xml
@@ -37,4 +37,8 @@
<Method name="getBuffer" />
<Bug pattern="EI_EXPOSE_REP" />
</Match>
+ <And>
+ <Bug category="MT_CORRECTNESS"/>
+ <Class name="~org.apache.bookkeeper.util.collections\.[^.]+"/>
+ </And>
</FindBugsFilter>