You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/10 03:23:09 UTC

[GitHub] [hudi] yihua opened a new pull request #4781: [MINOR] Fix typos in Spark client related classes

yihua opened a new pull request #4781:
URL: https://github.com/apache/hudi/pull/4781


   ## What is the purpose of the pull request
   
   This PR fixes a few typos in Spark client related classes.
   
   ## Verify this pull request
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yihua commented on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
yihua commented on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1051160823


   > > @yihua I see you changed many code styles e.g. import order, indent. Can we consider reusing spotless, [more detailed discussion](https://issues.apache.org/jira/browse/HUDI-304)? cc @xushiyan
   > 
   > @yanghua it's always on the tech debt list; just hasn't been prioritized yet. after 0.11 release maybe we should resume that work
   
   I missed this.  Currently, I rely on my IDE and Save Action plugin to do code style reformatting automatically, and that's how the imports are rearranged.  Yes, it would be great to bring back auto style reformatting using spotless.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1034502776


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5859",
       "triggerID" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a99182f1f0215bfa466b28e3b3313934e77bd0fe Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5859) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan merged pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
xushiyan merged pull request #4781:
URL: https://github.com/apache/hudi/pull/4781


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1034453835


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a99182f1f0215bfa466b28e3b3313934e77bd0fe UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot removed a comment on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1034455169


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5859",
       "triggerID" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a99182f1f0215bfa466b28e3b3313934e77bd0fe Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5859) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1038163809


   > @yihua I see you changed many code styles e.g. import order, indent. Can we consider reusing spotless, [more detailed discussion](https://issues.apache.org/jira/browse/HUDI-304)? cc @xushiyan
   
   @yanghua it's always on the tech debt list; just hasn't been prioritized yet. after 0.11 release maybe we should resume that work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
xushiyan commented on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1038163809


   > @yihua I see you changed many code styles e.g. import order, indent. Can we consider reusing spotless, [more detailed discussion](https://issues.apache.org/jira/browse/HUDI-304)? cc @xushiyan
   
   @yanghua it's always on the tech debt list; just hasn't been prioritized yet. after 0.11 release maybe we should resume that work


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1037241146


   @yihua I see you changed many code styles e.g. import order, indent. Can we consider reusing spotless, [more detailed discussion](https://issues.apache.org/jira/browse/HUDI-304)? cc @xushiyan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1034453835


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a99182f1f0215bfa466b28e3b3313934e77bd0fe UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] yanghua commented on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
yanghua commented on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1037241146


   @yihua I see you changed many code styles e.g. import order, indent. Can we consider reusing spotless, [more detailed discussion](https://issues.apache.org/jira/browse/HUDI-304)? cc @xushiyan 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan merged pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
xushiyan merged pull request #4781:
URL: https://github.com/apache/hudi/pull/4781


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #4781: [MINOR] Fix typos in Spark client related classes

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4781:
URL: https://github.com/apache/hudi/pull/4781#issuecomment-1034455169


   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5859",
       "triggerID" : "a99182f1f0215bfa466b28e3b3313934e77bd0fe",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a99182f1f0215bfa466b28e3b3313934e77bd0fe Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5859) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org