[GitHub] pierrekilly commented on issue #1160: Add support for Bcrypt password hashing

[GitBox <gi...@apache.org>]

pierrekilly commented on issue #1160: Add support for Bcrypt password hashing
URL: https://github.com/apache/couchdb/pull/1160#issuecomment-365265915
 
 
   Thanks @wohali for your review! I have to say this is the first time I contribute to a big opensource project, and the first time I work with Erlang!
   
   So If I understand well, I should at least do the following:
   - not use the default `iterations` that is used for PBKDF2 but create a new `log_rounds` config entry with its own default
   - rollback my change in pbkdf2's default iterations (if something should be fixed there, it should be fixed in a dedicated branch / commit / PR)
   
   Once this is done, **how should I proceed to work on a feature branch**? I've followed [the given instructions](https://github.com/apache/couchdb/blob/master/CONTRIBUTING.md#for-new-contributors) but maybe I made something wrong?
   
   I don't have a strong opinion about bcrypt vs. pbkdf2. I know both are great with there pros and cons. I happened to use Bcrypt so far and I have several dozens of thousands of user accounts who's passwords are stored in my MySQL database and as I want to migrate to CouchDB (because it's awesome!), the best for me is to have it support Bcrypt, so I can just import my user accounts without requiring any actions from them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services