[GitHub] [doris] morrySnow commented on a diff in pull request #10659: [enhancement](nereids) make aggregate works

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #10659:
URL: https://github.com/apache/doris/pull/10659#discussion_r915540173


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/Add.java:
##########
@@ -57,6 +57,6 @@ public <R, C> R accept(ExpressionVisitor<R, C> visitor, C context) {
 
 
     public String toString() {
-        return sql();
+        return left().toString() + ' ' + getArithmeticOperator().toString() + ' ' + right().sql();

Review Comment:
   so sleepy



##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/functions/Sum.java:
##########
@@ -51,7 +51,7 @@ public DataType getDataType() {
 
     @Override
     public boolean nullable() {
-        return false;
+        return child().nullable();

Review Comment:
   yes



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org