[GitHub] [iceberg] nastra commented on a change in pull request #2588: Bump Nessie to 0.8.2 + related changes

[GitBox <gi...@apache.org>]

nastra commented on a change in pull request #2588:
URL: https://github.com/apache/iceberg/pull/2588#discussion_r670469894



##########
File path: nessie/src/main/java/org/apache/iceberg/nessie/UpdateableReference.java
##########
@@ -44,6 +48,15 @@ public boolean refresh() throws NessieNotFoundException {
     return !oldReference.equals(reference);
   }
 
+  public void updateReference(Reference ref) {
+    Objects.requireNonNull(ref);
+    if (this.reference.getClass() != ref.getClass()) {

Review comment:
       nit: you could use `Preconditions.checkArgument(...)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org