You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/16 22:46:59 UTC

[GitHub] [spark] brkyvz opened a new pull request #26913: [SPARK-29219][SQL] Introduce SupportsCatalogOptions for TableProvider

brkyvz opened a new pull request #26913: [SPARK-29219][SQL] Introduce SupportsCatalogOptions for TableProvider
URL: https://github.com/apache/spark/pull/26913
 
 
   ### What changes were proposed in this pull request?
   
   This PR introduces `SupportsCatalogOptions` as an interface for `TableProvider`. Through `SupportsCatalogOptions`, V2 DataSources can implement the two methods `extractIdentifier` and `extractCatalog` to support the creation, and existence check of tables without requiring a formal TableCatalog implementation. 
   
   We currently don't support all SaveModes for DataSourceV2 in DataFrameWriter.save. The idea here is that eventually File based tables can be written with `DataFrameWriter.save(path)` will create a PathIdentifier where the name is `path`, and the V2SessionCatalog will be able to perform FileSystem checks at `path` to support ErrorIfExists and Ignore SaveModes.
   
   ### Why are the changes needed?
   
   To support all Save modes for V2 data sources with DataFrameWriter. Since we can now support table creation, we will be able to provide partitioning information when first creating the table as well.
   
   ### Does this PR introduce any user-facing change?
   
   Introduces a new interface
   
   ### How was this patch tested?
   
   Will add tests once interface is vetted.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org