You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/01/06 03:34:19 UTC
[GitHub] [kylin] vaful opened a new pull request #1043: KYLIN-4327 TOPN
Comparator may violate its general contract
vaful opened a new pull request #1043: KYLIN-4327 TOPN Comparator may violate its general contract
URL: https://github.com/apache/kylin/pull/1043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] codecov-io commented on issue #1043: KYLIN-4327 TOPN
Comparator may violate its general contract
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #1043: KYLIN-4327 TOPN Comparator may violate its general contract
URL: https://github.com/apache/kylin/pull/1043#issuecomment-570994403
# [Codecov](https://codecov.io/gh/apache/kylin/pull/1043?src=pr&el=h1) Report
> Merging [#1043](https://codecov.io/gh/apache/kylin/pull/1043?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/73c1a85fe5e3ee2a70592ca98f899b9f41dfc207?src=pr&el=desc) will **decrease** coverage by `0.63%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/kylin/pull/1043?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1043 +/- ##
===========================================
- Coverage 25.63% 25% -0.64%
- Complexity 6050 6180 +130
===========================================
Files 1398 1438 +40
Lines 83449 87669 +4220
Branches 11685 12255 +570
===========================================
+ Hits 21392 21918 +526
- Misses 60008 63598 +3590
- Partials 2049 2153 +104
```
| [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1043?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ava/org/apache/kylin/measure/topn/TopNCounter.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-Y29yZS1tZXRhZGF0YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3lsaW4vbWVhc3VyZS90b3BuL1RvcE5Db3VudGVyLmphdmE=) | `76.76% <100%> (+1.01%)` | `23 <0> (ø)` | :arrow_down: |
| [...ylin/source/jdbc/metadata/JdbcMetadataFactory.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL21ldGFkYXRhL0pkYmNNZXRhZGF0YUZhY3RvcnkuamF2YQ==) | `0% <0%> (-25%)` | `0% <0%> (-1%)` | |
| [...eam/coordinator/exception/CoordinateException.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-c3RyZWFtLWNvb3JkaW5hdG9yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9zdHJlYW0vY29vcmRpbmF0b3IvZXhjZXB0aW9uL0Nvb3JkaW5hdGVFeGNlcHRpb24uamF2YQ==) | `0% <0%> (-25%)` | `0% <0%> (-1%)` | |
| [...n/cube/model/validation/CubeMetadataValidator.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL21vZGVsL3ZhbGlkYXRpb24vQ3ViZU1ldGFkYXRhVmFsaWRhdG9yLmphdmE=) | `52.63% <0%> (-22.37%)` | `4% <0%> (+1%)` | |
| [...ylin/job/impl/threadpool/DefaultFetcherRunner.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-Y29yZS1qb2Ivc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2pvYi9pbXBsL3RocmVhZHBvb2wvRGVmYXVsdEZldGNoZXJSdW5uZXIuamF2YQ==) | `54.38% <0%> (-19.98%)` | `6% <0%> (ø)` | |
| [.../kylin/stream/core/storage/columnar/RawRecord.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-c3RyZWFtLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3N0cmVhbS9jb3JlL3N0b3JhZ2UvY29sdW1uYXIvUmF3UmVjb3JkLmphdmE=) | `46.87% <0%> (-15.63%)` | `7% <0%> (ø)` | |
| [...ain/java/org/apache/kylin/source/jdbc/SqlUtil.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL1NxbFV0aWwuamF2YQ==) | `43.24% <0%> (-13.52%)` | `20% <0%> (-2%)` | |
| [...ylin/source/jdbc/extensible/JdbcHiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL2V4dGVuc2libGUvSmRiY0hpdmVJbnB1dEJhc2UuamF2YQ==) | `71.42% <0%> (-12.58%)` | `2% <0%> (ø)` | |
| [...rg/apache/kylin/source/jdbc/JdbcHiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-c291cmNlLWpkYmMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9qZGJjL0pkYmNIaXZlSW5wdXRCYXNlLmphdmE=) | `9.05% <0%> (-12.06%)` | `7% <0%> (-1%)` | |
| [...he/kylin/engine/mr/common/MapReduceExecutable.java](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvY29tbW9uL01hcFJlZHVjZUV4ZWN1dGFibGUuamF2YQ==) | `13.33% <0%> (-9.4%)` | `6% <0%> (ø)` | |
| ... and [208 more](https://codecov.io/gh/apache/kylin/pull/1043/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1043?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1043?src=pr&el=footer). Last update [73c1a85...7cdb92f](https://codecov.io/gh/apache/kylin/pull/1043?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [kylin] nichunen merged pull request #1043: KYLIN-4327 TOPN
Comparator may violate its general contract
Posted by GitBox <gi...@apache.org>.
nichunen merged pull request #1043: KYLIN-4327 TOPN Comparator may violate its general contract
URL: https://github.com/apache/kylin/pull/1043
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services