You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Nicolas Liochon <nk...@gmail.com> on 2013/04/08 18:10:23 UTC
@Test(timeout = 1000)
Hi,
I see some tests with a test timeout of 1s.
The problem with this is that it may happen with a GC or anything on the
server.
Any issue to decide to have a minimum of 60s for such settings?
Thanks,
Nicolas
Re: @Test(timeout = 1000)
Posted by Ted <yu...@gmail.com>.
Minor correction: the JIRA number should be 8303
Cheers
On Apr 9, 2013, at 12:49 AM, Nicolas Liochon <nk...@gmail.com> wrote:
> I've created HBASE-8003 and bumped the tests I found with a timeout
> inferior to 30s to 60s.
> With this, if a timeout occurs, we know it's very likely to be the test or
> hbase, not the env :-)
>
>
>
> On Tue, Apr 9, 2013 at 5:06 AM, Enis Söztutar <en...@gmail.com> wrote:
>
>> +1 on increasing the timeouts for those to at least 10sec.
>>
>>
>> On Mon, Apr 8, 2013 at 9:19 AM, Ted Yu <yu...@gmail.com> wrote:
>>
>>> In trunk, I found 4 tests with such annotation.
>>> They're all small tests.
>>>
>>> I guess the intention was that GC wouldn't be long in a test where
>> cluster
>>> is not spun up.
>>>
>>> I think increasing the timeout should be fine.
>>>
>>> Cheers
>>>
>>> On Mon, Apr 8, 2013 at 9:10 AM, Nicolas Liochon <nk...@gmail.com>
>> wrote:
>>>
>>>> Hi,
>>>>
>>>> I see some tests with a test timeout of 1s.
>>>> The problem with this is that it may happen with a GC or anything on
>> the
>>>> server.
>>>>
>>>> Any issue to decide to have a minimum of 60s for such settings?
>>>>
>>>> Thanks,
>>>>
>>>> Nicolas
>>
Re: @Test(timeout = 1000)
Posted by Nicolas Liochon <nk...@gmail.com>.
I've created HBASE-8003 and bumped the tests I found with a timeout
inferior to 30s to 60s.
With this, if a timeout occurs, we know it's very likely to be the test or
hbase, not the env :-)
On Tue, Apr 9, 2013 at 5:06 AM, Enis Söztutar <en...@gmail.com> wrote:
> +1 on increasing the timeouts for those to at least 10sec.
>
>
> On Mon, Apr 8, 2013 at 9:19 AM, Ted Yu <yu...@gmail.com> wrote:
>
> > In trunk, I found 4 tests with such annotation.
> > They're all small tests.
> >
> > I guess the intention was that GC wouldn't be long in a test where
> cluster
> > is not spun up.
> >
> > I think increasing the timeout should be fine.
> >
> > Cheers
> >
> > On Mon, Apr 8, 2013 at 9:10 AM, Nicolas Liochon <nk...@gmail.com>
> wrote:
> >
> > > Hi,
> > >
> > > I see some tests with a test timeout of 1s.
> > > The problem with this is that it may happen with a GC or anything on
> the
> > > server.
> > >
> > > Any issue to decide to have a minimum of 60s for such settings?
> > >
> > > Thanks,
> > >
> > > Nicolas
> > >
> >
>
Re: @Test(timeout = 1000)
Posted by Enis Söztutar <en...@gmail.com>.
+1 on increasing the timeouts for those to at least 10sec.
On Mon, Apr 8, 2013 at 9:19 AM, Ted Yu <yu...@gmail.com> wrote:
> In trunk, I found 4 tests with such annotation.
> They're all small tests.
>
> I guess the intention was that GC wouldn't be long in a test where cluster
> is not spun up.
>
> I think increasing the timeout should be fine.
>
> Cheers
>
> On Mon, Apr 8, 2013 at 9:10 AM, Nicolas Liochon <nk...@gmail.com> wrote:
>
> > Hi,
> >
> > I see some tests with a test timeout of 1s.
> > The problem with this is that it may happen with a GC or anything on the
> > server.
> >
> > Any issue to decide to have a minimum of 60s for such settings?
> >
> > Thanks,
> >
> > Nicolas
> >
>
Re: @Test(timeout = 1000)
Posted by Ted Yu <yu...@gmail.com>.
In trunk, I found 4 tests with such annotation.
They're all small tests.
I guess the intention was that GC wouldn't be long in a test where cluster
is not spun up.
I think increasing the timeout should be fine.
Cheers
On Mon, Apr 8, 2013 at 9:10 AM, Nicolas Liochon <nk...@gmail.com> wrote:
> Hi,
>
> I see some tests with a test timeout of 1s.
> The problem with this is that it may happen with a GC or anything on the
> server.
>
> Any issue to decide to have a minimum of 60s for such settings?
>
> Thanks,
>
> Nicolas
>