You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/05/27 20:10:51 UTC
Review Request 34723: RU: Storm actions require Zookeeper host
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34723/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-11438
https://issues.apache.org/jira/browse/AMBARI-11438
Repository: ambari
Description
-------
Two Storm issues occurred during HDP-2.2 -> HDP-2.3 RU, both the same issue. Occurs when the Storm packages are NOT on the same host as any zookeeper servers.
* Nimbus prepare invokes a zkCli.sh command to remove /storm
* Storm service check appears to have the same issue when not on the ZK servers.
The solution here is to use the zookeeper servers property from storm-site and pass in -server to zkCli.sh
Diffs
-----
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 5ae7170
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py b25cdf8
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py 7b71553
ambari-server/src/test/python/stacks/2.3/STORM/test_yaml_utils.py PRE-CREATION
Diff: https://reviews.apache.org/r/34723/diff/
Testing
-------
Upgraded storm with Nimbus on a host that did not have ZK.
----------------------------------------------------------------------
Total run:744
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
Re: Review Request 34723: RU: Storm actions require Zookeeper host
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34723/#review85414
-----------------------------------------------------------
Ship it!
Fix It and Ship It
- Alejandro Fernandez
On May 27, 2015, 6:10 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34723/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 6:10 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-11438
> https://issues.apache.org/jira/browse/AMBARI-11438
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Storm issues occurred during HDP-2.2 -> HDP-2.3 RU, both the same issue. Occurs when the Storm packages are NOT on the same host as any zookeeper servers.
>
> * Nimbus prepare invokes a zkCli.sh command to remove /storm
> * Storm service check appears to have the same issue when not on the ZK servers.
>
> The solution here is to use the zookeeper servers property from storm-site and pass in -server to zkCli.sh
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 5ae7170
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py b25cdf8
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py 7b71553
> ambari-server/src/test/python/stacks/2.3/STORM/test_yaml_utils.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34723/diff/
>
>
> Testing
> -------
>
> Upgraded storm with Nimbus on a host that did not have ZK.
>
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 34723: RU: Storm actions require Zookeeper host
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34723/#review85422
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On May 27, 2015, 7:24 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34723/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 7:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-11438
> https://issues.apache.org/jira/browse/AMBARI-11438
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Storm issues occurred during HDP-2.2 -> HDP-2.3 RU, both the same issue. Occurs when the Storm packages are NOT on the same host as any zookeeper servers.
>
> * Nimbus prepare invokes a zkCli.sh command to remove /storm
> * Storm service check appears to have the same issue when not on the ZK servers.
>
> The solution here is to use the zookeeper servers property from storm-site and pass in -server to zkCli.sh
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/ambari_commons/yaml_utils.py PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 5ae7170
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py e7e5a4c
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py b25cdf8
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_yaml_utils.py PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py 7b71553
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_base.py 8d82f2a
> ambari-server/src/test/python/stacks/2.3/STORM/test_storm_base.py e0a050f
> ambari-server/src/test/python/stacks/2.3/STORM/test_yaml_utils.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34723/diff/
>
>
> Testing
> -------
>
> Upgraded storm with Nimbus on a host that did not have ZK.
>
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 34723: RU: Storm actions require Zookeeper host
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34723/#review85458
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On May 27, 2015, 3:24 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34723/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 3:24 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-11438
> https://issues.apache.org/jira/browse/AMBARI-11438
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Storm issues occurred during HDP-2.2 -> HDP-2.3 RU, both the same issue. Occurs when the Storm packages are NOT on the same host as any zookeeper servers.
>
> * Nimbus prepare invokes a zkCli.sh command to remove /storm
> * Storm service check appears to have the same issue when not on the ZK servers.
>
> The solution here is to use the zookeeper servers property from storm-site and pass in -server to zkCli.sh
>
>
> Diffs
> -----
>
> ambari-common/src/main/python/ambari_commons/yaml_utils.py PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 5ae7170
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py e7e5a4c
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py b25cdf8
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_yaml_utils.py PRE-CREATION
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py 7b71553
> ambari-server/src/test/python/stacks/2.1/STORM/test_storm_base.py 8d82f2a
> ambari-server/src/test/python/stacks/2.3/STORM/test_storm_base.py e0a050f
> ambari-server/src/test/python/stacks/2.3/STORM/test_yaml_utils.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34723/diff/
>
>
> Testing
> -------
>
> Upgraded storm with Nimbus on a host that did not have ZK.
>
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 34723: RU: Storm actions require Zookeeper host
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34723/
-----------------------------------------------------------
(Updated May 27, 2015, 3:24 p.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-11438
https://issues.apache.org/jira/browse/AMBARI-11438
Repository: ambari
Description
-------
Two Storm issues occurred during HDP-2.2 -> HDP-2.3 RU, both the same issue. Occurs when the Storm packages are NOT on the same host as any zookeeper servers.
* Nimbus prepare invokes a zkCli.sh command to remove /storm
* Storm service check appears to have the same issue when not on the ZK servers.
The solution here is to use the zookeeper servers property from storm-site and pass in -server to zkCli.sh
Diffs (updated)
-----
ambari-common/src/main/python/ambari_commons/yaml_utils.py PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 5ae7170
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm.py e7e5a4c
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py b25cdf8
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_yaml_utils.py PRE-CREATION
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py 7b71553
ambari-server/src/test/python/stacks/2.1/STORM/test_storm_base.py 8d82f2a
ambari-server/src/test/python/stacks/2.3/STORM/test_storm_base.py e0a050f
ambari-server/src/test/python/stacks/2.3/STORM/test_yaml_utils.py PRE-CREATION
Diff: https://reviews.apache.org/r/34723/diff/
Testing
-------
Upgraded storm with Nimbus on a host that did not have ZK.
----------------------------------------------------------------------
Total run:744
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
Re: Review Request 34723: RU: Storm actions require Zookeeper host
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34723/
-----------------------------------------------------------
(Updated May 27, 2015, 3:22 p.m.)
Review request for Ambari, Alejandro Fernandez and Nate Cole.
Bugs: AMBARI-11438
https://issues.apache.org/jira/browse/AMBARI-11438
Repository: ambari
Description
-------
Two Storm issues occurred during HDP-2.2 -> HDP-2.3 RU, both the same issue. Occurs when the Storm packages are NOT on the same host as any zookeeper servers.
* Nimbus prepare invokes a zkCli.sh command to remove /storm
* Storm service check appears to have the same issue when not on the ZK servers.
The solution here is to use the zookeeper servers property from storm-site and pass in -server to zkCli.sh
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 5ae7170
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py b25cdf8
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py 7b71553
ambari-server/src/test/python/stacks/2.3/STORM/test_yaml_utils.py PRE-CREATION
Diff: https://reviews.apache.org/r/34723/diff/
Testing
-------
Upgraded storm with Nimbus on a host that did not have ZK.
----------------------------------------------------------------------
Total run:744
Total errors:0
Total failures:0
OK
Thanks,
Jonathan Hurley
Re: Review Request 34723: RU: Storm actions require Zookeeper host
Posted by Jonathan Hurley <jh...@hortonworks.com>.
> On May 27, 2015, 2:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py, line 59
> > <https://reviews.apache.org/r/34723/diff/1/?file=972965#file972965line59>
> >
> > Won't this raise an exception trying to get the value if it's not in the config dictionary?
> > Perhaps params.storm_zookeeper_servers should still use the default(..., None) notation.
Yes, but the value exists in the base STORM storm-site and it's required for Storm to work, so it should be there. If not, there are larger problems.
> On May 27, 2015, 2:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py, line 86
> > <https://reviews.apache.org/r/34723/diff/1/?file=972965#file972965line86>
> >
> > If it fails on all ZK clients then no exception will be raised.
Good point, let me Fail(...) if that happens.
> On May 27, 2015, 2:27 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py, line 83
> > <https://reviews.apache.org/r/34723/diff/1/?file=972966#file972966line83>
> >
> > Can we move this to ambari-common?
We can; I wonder if there are any storm-specific things in here though. I'll see about moving it...
- Jonathan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34723/#review85406
-----------------------------------------------------------
On May 27, 2015, 2:10 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34723/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 2:10 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-11438
> https://issues.apache.org/jira/browse/AMBARI-11438
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Storm issues occurred during HDP-2.2 -> HDP-2.3 RU, both the same issue. Occurs when the Storm packages are NOT on the same host as any zookeeper servers.
>
> * Nimbus prepare invokes a zkCli.sh command to remove /storm
> * Storm service check appears to have the same issue when not on the ZK servers.
>
> The solution here is to use the zookeeper servers property from storm-site and pass in -server to zkCli.sh
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 5ae7170
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py b25cdf8
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py 7b71553
> ambari-server/src/test/python/stacks/2.3/STORM/test_yaml_utils.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34723/diff/
>
>
> Testing
> -------
>
> Upgraded storm with Nimbus on a host that did not have ZK.
>
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 34723: RU: Storm actions require Zookeeper host
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34723/#review85406
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py
<https://reviews.apache.org/r/34723/#comment136957>
Won't this raise an exception trying to get the value if it's not in the config dictionary?
Perhaps params.storm_zookeeper_servers should still use the default(..., None) notation.
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py
<https://reviews.apache.org/r/34723/#comment136958>
If it fails on all ZK clients then no exception will be raised.
ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py
<https://reviews.apache.org/r/34723/#comment136959>
Can we move this to ambari-common?
- Alejandro Fernandez
On May 27, 2015, 6:10 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34723/
> -----------------------------------------------------------
>
> (Updated May 27, 2015, 6:10 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
>
>
> Bugs: AMBARI-11438
> https://issues.apache.org/jira/browse/AMBARI-11438
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Two Storm issues occurred during HDP-2.2 -> HDP-2.3 RU, both the same issue. Occurs when the Storm packages are NOT on the same host as any zookeeper servers.
>
> * Nimbus prepare invokes a zkCli.sh command to remove /storm
> * Storm service check appears to have the same issue when not on the ZK servers.
>
> The solution here is to use the zookeeper servers property from storm-site and pass in -server to zkCli.sh
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/params_linux.py 5ae7170
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/storm_upgrade.py b25cdf8
> ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/yaml_utils.py 7b71553
> ambari-server/src/test/python/stacks/2.3/STORM/test_yaml_utils.py PRE-CREATION
>
> Diff: https://reviews.apache.org/r/34723/diff/
>
>
> Testing
> -------
>
> Upgraded storm with Nimbus on a host that did not have ZK.
>
> ----------------------------------------------------------------------
> Total run:744
> Total errors:0
> Total failures:0
> OK
>
>
> Thanks,
>
> Jonathan Hurley
>
>