You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hive.apache.org by ha...@apache.org on 2012/11/14 03:57:16 UTC
svn commit: r1409066 - in /hive/trunk:
common/src/java/org/apache/hadoop/hive/conf/
metastore/src/java/org/apache/hadoop/hive/metastore/
ql/src/java/org/apache/hadoop/hive/ql/metadata/
Author: hashutosh
Date: Wed Nov 14 02:57:15 2012
New Revision: 1409066
URL: http://svn.apache.org/viewvc?rev=1409066&view=rev
Log:
HIVE-3560 : Hive always prints a warning message when using remote metastore (Travis Crawford via Ashutosh Chauhan)
Modified:
hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
Modified: hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
URL: http://svn.apache.org/viewvc/hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java?rev=1409066&r1=1409065&r2=1409066&view=diff
==============================================================================
--- hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (original)
+++ hive/trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Wed Nov 14 02:57:15 2012
@@ -996,13 +996,6 @@ public class HiveConf extends Configurat
"connecting to a remote metastore.");
}
- if (null != this.get(ConfVars.METASTOREURIS.varname, null) &&
- null != this.get(ConfVars.METASTORECONNECTURLKEY.varname, null)) {
- l4j.error("Found both " + ConfVars.METASTOREURIS.varname + " and " +
- ConfVars.METASTORECONNECTURLKEY + " Recommended to have exactly one of those config key" +
- "in configuration");
- }
-
// if the running class was loaded directly (through eclipse) rather than through a
// jar then this would be needed
if (hiveJar == null) {
Modified: hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java
URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java?rev=1409066&r1=1409065&r2=1409066&view=diff
==============================================================================
--- hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java (original)
+++ hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java Wed Nov 14 02:57:15 2012
@@ -197,21 +197,21 @@ public class HiveMetaStoreClient impleme
private void open() throws MetaException {
for (URI store : metastoreUris) {
- LOG.info("Trying to connect to metastore with URI " + store);
+ LOG.info("Trying to connect to HiveMetaStore with URI " + store);
try {
openStore(store);
} catch (MetaException e) {
- LOG.error("Unable to connect to metastore with URI " + store, e);
+ LOG.error("Unable to connect to HiveMetaStore with URI " + store, e);
}
if (isConnected) {
+ LOG.info("Connected to HiveMetaStore with URI " + store);
break;
}
}
if (!isConnected) {
- throw new MetaException(
- "Could not connect to meta store using any of the URIs provided");
+ throw new MetaException("Could not connect to HiveMetaStore using any of the provided URIs: "
+ + Arrays.asList(metastoreUris));
}
- LOG.info("Connected to metastore.");
}
private void openStore(URI store) throws MetaException {
Modified: hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
URL: http://svn.apache.org/viewvc/hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java?rev=1409066&r1=1409065&r2=1409066&view=diff
==============================================================================
--- hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java (original)
+++ hive/trunk/metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java Wed Nov 14 02:57:15 2012
@@ -483,7 +483,7 @@ public class MetaStoreUtils {
}
ddl.append("}");
- LOG.info("DDL: " + ddl);
+ LOG.debug("DDL: " + ddl);
return ddl.toString();
}
Modified: hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java
URL: http://svn.apache.org/viewvc/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java?rev=1409066&r1=1409065&r2=1409066&view=diff
==============================================================================
--- hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java (original)
+++ hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Wed Nov 14 02:57:15 2012
@@ -195,7 +195,7 @@ public class Hive {
* closes the connection to metastore for the calling thread
*/
private void close() {
- LOG.info("Closing current thread's connection to Hive Metastore.");
+ LOG.debug("Closing current thread's connection to Hive Metastore.");
if (metaStoreClient != null) {
metaStoreClient.close();
metaStoreClient = null;