You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "aherbert (via GitHub)" <gi...@apache.org> on 2023/07/26 14:45:32 UTC

[GitHub] [commons-collections] aherbert commented on pull request #407: Make AbstractPatriciaTrie public

aherbert commented on PR #407:
URL: https://github.com/apache/commons-collections/pull/407#issuecomment-1651958544

   The use case merits it being made public. Note that if we make it public then it needs some more javadoc as it will now appear in the javadoc API. The types <K, V> are not documented, e.g. are there limitations? One of the constructors has no javadoc, the other has no documentation of the parameters. IIUC the minimal effort would be to copy what is in the superclass `AbstractBitwiseTrie` for the type parameters and the constructors. I did not check the rest of the rendered javadoc but this should be done for completeness.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org