You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by "psalagnac (via GitHub)" <gi...@apache.org> on 2024/02/15 14:25:33 UTC
[PR] SOLR-17160: Time based tracking of core admin requests [solr]
psalagnac opened a new pull request, #2271:
URL: https://github.com/apache/solr/pull/2271
https://issues.apache.org/jira/browse/SOLR-17160
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Solr:
* https://issues.apache.org/jira/projects/SOLR
For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA.
To create a Jira issue, you will need to create an account there first.
The title of the PR should reference the Jira issue number in the form:
* SOLR-####: <short description of problem or changes>
SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
Core admin completed/failed requests are tracked in-memory, but we only track a maximum of 100 requests by dropping the oldest ones. If for any reason we drop a request before the client (an other Solr node) fetched the status, we will get unexpected errors at the top level command.
# Solution
Instead of the hard limit of 100 tracked requests, we track all requests with a expiration timeout. This is a trade-off to not keep memory forever and to be sure we won't lose status in the case of many incoming requests.
The change adds two different timeouts:
- an hour for every requests (overridable with property `"solr.admin.requests.running.timeout.minutes"`)
- 5 minutes for completed/failed requests once the status is already retrieved by client (overridable with property `"solr.admin.requests.completed.timeout.minutes"`)
# Tests
Added a unit test in `CoreAdminHandlerTest` to check expired requests are not tracked in-memory anymore.
Also checks we don't have any issue for collection backup with very high numbers of shards.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://github.com/apache/solr/blob/main/CONTRIBUTING.md) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `main` branch.
- [x] I have run `./gradlew check`.
- [x] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17160: Time based tracking of core admin requests [solr]
Posted by "psalagnac (via GitHub)" <gi...@apache.org>.
psalagnac commented on PR #2271:
URL: https://github.com/apache/solr/pull/2271#issuecomment-1965436549
> Instead of the manual cache management, can't we use CaffeineCache as is used elsewhere in Solr? CC @bruno-roustant
Thanks for the suggestion. I filled #2304 that achieves the same, with a Caffeine cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
Re: [PR] SOLR-17160: Time based tracking of core admin requests [solr]
Posted by "dsmiley (via GitHub)" <gi...@apache.org>.
dsmiley closed pull request #2271: SOLR-17160: Time based tracking of core admin requests
URL: https://github.com/apache/solr/pull/2271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org