You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "potiuk (via GitHub)" <gi...@apache.org> on 2023/07/09 17:14:43 UTC
[GitHub] [airflow] potiuk opened a new pull request, #32463: Auto-detect docker context for breeze commands
potiuk opened a new pull request, #32463:
URL: https://github.com/apache/airflow/pull/32463
Recently Docker Desktop - particularly on Mac OS disabled creation of /var/run/docker.sock by default, leaving it only as advanced option, thus deprecating the "default" context for docker.
So far we recommended to enable the option for Breeze, but this change allows to autodetect if there is a "desktop-linux" context available (which uses a user-home-dir socket instead of the global /var/run one) and if it gets detected, "desktop-linux" context is used.
This is slightly more complicated, because we need to also leave the ``--builder`` available for cases where our auto-detection fails, so we need to expose the option in all commands that might attempt to build image automatically, we also need to find and forward the right socket to inside breeze - as we cannot unconditionally forward the /var/run/docker.sock.
Alongside the chage "static-checks" command gets the same capability of rebuilding the CI image automatically.
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] utkarsharma2 commented on pull request #32463: Auto-detect docker context for breeze commands
Posted by "utkarsharma2 (via GitHub)" <gi...@apache.org>.
utkarsharma2 commented on PR #32463:
URL: https://github.com/apache/airflow/pull/32463#issuecomment-1627784990
@potiuk Thanks for looking into this, recently faced issues. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #32463: Auto-detect docker context for breeze commands
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #32463:
URL: https://github.com/apache/airflow/pull/32463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org