You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@paimon.apache.org by cz...@apache.org on 2026/03/25 07:07:31 UTC
(paimon) branch master updated: [core] CastFieldGetter throw exception with field when cast fail (#7515)
This is an automated email from the ASF dual-hosted git repository.
czweng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/paimon.git
The following commit(s) were added to refs/heads/master by this push:
new 7a76c43079 [core] CastFieldGetter throw exception with field when cast fail (#7515)
7a76c43079 is described below
commit 7a76c43079bfd9ecdcbbf80c80eda0ea4ed45f73
Author: Jingsong Lee <ji...@gmail.com>
AuthorDate: Wed Mar 25 15:07:25 2026 +0800
[core] CastFieldGetter throw exception with field when cast fail (#7515)
### Purpose
Purpose: To include field names in exception information when type
conversion fails, helping users locate the problem faster.
### Tests
`DataTypeCastTableTest`
---
.../org/apache/paimon/casting/CastFieldGetter.java | 19 +++-
.../apache/paimon/schema/SchemaEvolutionUtil.java | 10 +-
.../apache/paimon/table/DataTypeCastTableTest.java | 101 +++++++++++++++++++++
3 files changed, 125 insertions(+), 5 deletions(-)
diff --git a/paimon-common/src/main/java/org/apache/paimon/casting/CastFieldGetter.java b/paimon-common/src/main/java/org/apache/paimon/casting/CastFieldGetter.java
index 208ef5f30f..c0c1c31e4a 100644
--- a/paimon-common/src/main/java/org/apache/paimon/casting/CastFieldGetter.java
+++ b/paimon-common/src/main/java/org/apache/paimon/casting/CastFieldGetter.java
@@ -27,16 +27,31 @@ public class CastFieldGetter {
private final InternalRow.FieldGetter fieldGetter;
private final CastExecutor<Object, Object> castExecutor;
+ private final String fieldName;
@SuppressWarnings("unchecked")
- public CastFieldGetter(InternalRow.FieldGetter fieldGetter, CastExecutor<?, ?> castExecutor) {
+ public CastFieldGetter(
+ InternalRow.FieldGetter fieldGetter,
+ CastExecutor<?, ?> castExecutor,
+ String fieldName) {
this.fieldGetter = fieldGetter;
this.castExecutor = (CastExecutor<Object, Object>) castExecutor;
+ this.fieldName = fieldName;
}
@SuppressWarnings("unchecked")
public <V> V getFieldOrNull(InternalRow row) {
Object value = fieldGetter.getFieldOrNull(row);
- return value == null ? null : (V) castExecutor.cast(value);
+ if (value == null) {
+ return null;
+ }
+ try {
+ return (V) castExecutor.cast(value);
+ } catch (Exception e) {
+ throw new RuntimeException(
+ String.format(
+ "Failed to cast value for field '%s': %s", fieldName, e.getMessage()),
+ e);
+ }
}
}
diff --git a/paimon-core/src/main/java/org/apache/paimon/schema/SchemaEvolutionUtil.java b/paimon-core/src/main/java/org/apache/paimon/schema/SchemaEvolutionUtil.java
index 694d2b1a55..05fb9be9f8 100644
--- a/paimon-core/src/main/java/org/apache/paimon/schema/SchemaEvolutionUtil.java
+++ b/paimon-core/src/main/java/org/apache/paimon/schema/SchemaEvolutionUtil.java
@@ -223,12 +223,15 @@ public class SchemaEvolutionUtil {
boolean castExist = false;
for (int i = 0; i < tableFields.size(); i++) {
+ DataField tableField = tableFields.get(i);
int dataIndex = indexMapping == null ? i : indexMapping[i];
if (dataIndex < 0) {
converterMapping[i] =
- new CastFieldGetter(row -> null, CastExecutors.identityCastExecutor());
+ new CastFieldGetter(
+ row -> null,
+ CastExecutors.identityCastExecutor(),
+ tableField.name());
} else {
- DataField tableField = tableFields.get(i);
DataField dataField = dataFields.get(dataIndex);
if (!dataField.type().equalsIgnoreNullable(tableField.type())) {
castExist = true;
@@ -238,7 +241,8 @@ public class SchemaEvolutionUtil {
converterMapping[i] =
new CastFieldGetter(
InternalRowUtils.createNullCheckingFieldGetter(dataField.type(), i),
- createCastExecutor(dataField.type(), tableField.type()));
+ createCastExecutor(dataField.type(), tableField.type()),
+ tableField.name());
}
}
diff --git a/paimon-core/src/test/java/org/apache/paimon/table/DataTypeCastTableTest.java b/paimon-core/src/test/java/org/apache/paimon/table/DataTypeCastTableTest.java
new file mode 100644
index 0000000000..90f3af35ef
--- /dev/null
+++ b/paimon-core/src/test/java/org/apache/paimon/table/DataTypeCastTableTest.java
@@ -0,0 +1,101 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.paimon.table;
+
+import org.apache.paimon.data.BinaryString;
+import org.apache.paimon.data.GenericRow;
+import org.apache.paimon.schema.Schema;
+import org.apache.paimon.schema.SchemaChange;
+import org.apache.paimon.types.DataTypes;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Test for data type cast error message contains column name. */
+public class DataTypeCastTableTest extends TableTestBase {
+
+ @Test
+ public void testStringToIntCastErrorMessageContainsColumnName() throws Exception {
+ // Create table with STRING column
+ Schema schema =
+ Schema.newBuilder()
+ .column("pk", DataTypes.INT())
+ .column("str_col", DataTypes.STRING())
+ .primaryKey("pk")
+ .option("bucket", "1")
+ .build();
+ catalog.createTable(identifier("CastTestTable"), schema, true);
+
+ // Write data with non-numeric string that cannot be cast to INT
+ FileStoreTable table = getTable(identifier("CastTestTable"));
+ write(
+ table,
+ GenericRow.of(1, BinaryString.fromString("not_a_number")),
+ GenericRow.of(2, BinaryString.fromString("123")),
+ GenericRow.of(3, BinaryString.fromString("invalid_value")));
+
+ // Alter table: change column type from STRING to INT
+ catalog.alterTable(
+ identifier("CastTestTable"),
+ Collections.singletonList(
+ SchemaChange.updateColumnType("str_col", DataTypes.INT())),
+ false);
+
+ // Read the table, should throw exception with column name in message
+ FileStoreTable alteredTable = getTable(identifier("CastTestTable"));
+ assertThatThrownBy(() -> read(alteredTable))
+ .isInstanceOf(RuntimeException.class)
+ .hasMessageContaining("Failed to cast value for field 'str_col'");
+ }
+
+ @Test
+ public void testStringToIntCastSuccess() throws Exception {
+ // Create table with STRING column
+ Schema schema =
+ Schema.newBuilder()
+ .column("pk", DataTypes.INT())
+ .column("str_col", DataTypes.STRING())
+ .primaryKey("pk")
+ .option("bucket", "1")
+ .build();
+ catalog.createTable(identifier("CastSuccessTable"), schema, true);
+
+ // Write data with numeric strings that can be cast to INT
+ FileStoreTable table = getTable(identifier("CastSuccessTable"));
+ write(
+ table,
+ GenericRow.of(1, BinaryString.fromString("100")),
+ GenericRow.of(2, BinaryString.fromString("200")),
+ GenericRow.of(3, BinaryString.fromString("300")));
+
+ // Alter table: change column type from STRING to INT
+ catalog.alterTable(
+ identifier("CastSuccessTable"),
+ Collections.singletonList(
+ SchemaChange.updateColumnType("str_col", DataTypes.INT())),
+ false);
+
+ // Read should succeed
+ FileStoreTable alteredTable = getTable(identifier("CastSuccessTable"));
+ read(alteredTable);
+ }
+}