You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2019/03/08 15:35:48 UTC

[incubator-skywalking] branch topology created (now c9a101b)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a change to branch topology
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git.


      at c9a101b  If the node has no interaction, then it disappear in topology.

This branch includes the following new commits:

     new c9a101b  If the node has no interaction, then it disappear in topology.

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



[incubator-skywalking] 01/01: If the node has no interaction, then it disappear in topology.

Posted by wu...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch topology
in repository https://gitbox.apache.org/repos/asf/incubator-skywalking.git

commit c9a101bad7d97901d4880e49373421ceeddc5eeb
Author: Wu Sheng <wu...@foxmail.com>
AuthorDate: Fri Mar 8 23:35:35 2019 +0800

    If the node has no interaction, then it disappear in topology.
---
 .../oap/server/core/query/TopologyQueryService.java | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TopologyQueryService.java b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TopologyQueryService.java
index a571eeb..667941b 100644
--- a/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TopologyQueryService.java
+++ b/oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/query/TopologyQueryService.java
@@ -84,30 +84,9 @@ public class TopologyQueryService implements Service {
         List<Call> serviceRelationServerCalls = getTopologyQueryDAO().loadServerSideServiceRelations(step, startTB, endTB);
         List<Call> serviceRelationClientCalls = getTopologyQueryDAO().loadClientSideServiceRelations(step, startTB, endTB);
 
-        List<org.apache.skywalking.oap.server.core.query.entity.Service> serviceList = getMetadataQueryDAO().searchServices(startTimestamp, endTimestamp, Const.EMPTY_STRING);
-
         TopologyBuilder builder = new TopologyBuilder(moduleManager);
         Topology topology = builder.build(serviceRelationClientCalls, serviceRelationServerCalls);
 
-        serviceList.forEach(service -> {
-            boolean contains = false;
-            for (Node node : topology.getNodes()) {
-                if (service.getId() == node.getId()) {
-                    contains = true;
-                    break;
-                }
-            }
-
-            if (!contains) {
-                Node newNode = new Node();
-                newNode.setId(service.getId());
-                newNode.setName(service.getName());
-                newNode.setReal(true);
-                newNode.setType(Const.UNKNOWN);
-                topology.getNodes().add(newNode);
-            }
-        });
-
         return topology;
     }