You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by sureshsubbiah <gi...@git.apache.org> on 2016/01/07 20:44:47 UTC
[GitHub] incubator-trafodion pull request: [TRAFODION-1742] Failure of cert...
GitHub user sureshsubbiah opened a pull request:
https://github.com/apache/incubator-trafodion/pull/252
[TRAFODION-1742] Failure of certain Hive regression tests on HDP alone
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sureshsubbiah/incubator-trafodion hive2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-trafodion/pull/252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #252
----
commit b8999c8e17e0353ccd2977f40d0ae9139a052556
Author: Suresh Subbiah <su...@apache.org>
Date: 2016-01-07T17:58:15Z
[TRAFODION-1742] Failure of certain Hive regression tests in HDP platform
This change fixes a mistake in error handling when Hive metadata string is
parsed to convert it into a compiler data structure.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1742] Failure of cert...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/252#discussion_r49123369
--- Diff: core/sql/executor/hiveHook.cpp ---
@@ -319,7 +319,7 @@ struct hive_sd_desc* populateSD(HiveMetaData *md, Int32 mainSdID,
// TODO : loop over SDs
if (findAToken(md, tblStr, pos, "sd:StorageDescriptor(",
- "getTableDesc::sd:StorageDescriptor(###"))
+ "getTableDesc::sd:StorageDescriptor(###"),FALSE)
--- End diff --
Ok looks like the right fix then. We don't want this error text to show up for some other NATable error.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1742] Failure of cert...
Posted by sureshsubbiah <gi...@git.apache.org>.
Github user sureshsubbiah commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/252#discussion_r49122116
--- Diff: core/sql/executor/hiveHook.cpp ---
@@ -319,7 +319,7 @@ struct hive_sd_desc* populateSD(HiveMetaData *md, Int32 mainSdID,
// TODO : loop over SDs
if (findAToken(md, tblStr, pos, "sd:StorageDescriptor(",
- "getTableDesc::sd:StorageDescriptor(###"))
+ "getTableDesc::sd:StorageDescriptor(###"),FALSE)
--- End diff --
Unlike other findAToken calls, this one expects to not find the token. If a token is indeed found we return NULL and will not create a NATable object. In the typical case, findAToken will return False and control will pass to line 325. If the last argument to findAToken, raiseError uses the default value of TRUE we will add an error detail text to the HiveMetaDB object. This error detail information will be used in NATable.cpp when error 1192 is raised. I think in the problem case we have the error detail text as always (which is usually harmless) but then later in the code path we get triggered onto raising an error in NAtable.cpp and use this older error detail text, thus maybe hiding the real error.
The metadata string returned by Hive in HDP when the test fails is the exact same as what we usually get.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1742] Failure of cert...
Posted by sandhyasun <gi...@git.apache.org>.
Github user sandhyasun commented on a diff in the pull request:
https://github.com/apache/incubator-trafodion/pull/252#discussion_r49120536
--- Diff: core/sql/executor/hiveHook.cpp ---
@@ -319,7 +319,7 @@ struct hive_sd_desc* populateSD(HiveMetaData *md, Int32 mainSdID,
// TODO : loop over SDs
if (findAToken(md, tblStr, pos, "sd:StorageDescriptor(",
- "getTableDesc::sd:StorageDescriptor(###"))
+ "getTableDesc::sd:StorageDescriptor(###"),FALSE)
--- End diff --
Is the idea to suppress the error and see if the hive operation succeeds ? All the other calls above this seem to default to TRUE?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-trafodion pull request: [TRAFODION-1742] Failure of cert...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-trafodion/pull/252
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---