You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/16 02:36:01 UTC

[GitHub] [nifi] exceptionfactory opened a new pull request, #6666: NIFI-10826 Separate Maven Compile and Verify in ci-workflow

exceptionfactory opened a new pull request, #6666:
URL: https://github.com/apache/nifi/pull/6666

   # Summary
   
   [NIFI-10826](https://issues.apache.org/jira/browse/NIFI-10826) Separates Maven compilation and verification into separate build steps within the GitHub ci-workflow configuration.
   
   The updated ci-workflow includes a Maven Compile step that calls `mvn compile` with two threads per core and excludes several assembly that are not necessary for initial compilation. The subsequent Maven Verify step calls `mvn verify` with existing arguments to run standard unit tests.
   
   Additional changes include adjusting the lifecycle phase for `nifi-h2-database` to be invoked during compilation, and shifting NiFi Registry documentation unpacking to the `prepare-package` phase where it is needed.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 8
     - [X] JDK 11
     - [X] JDK 17
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 closed pull request #6666: NIFI-10826 Separate Maven Compile and Verify in ci-workflow

Posted by GitBox <gi...@apache.org>.
mattyb149 closed pull request #6666: NIFI-10826 Separate Maven Compile and Verify in ci-workflow
URL: https://github.com/apache/nifi/pull/6666


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi] mattyb149 commented on pull request #6666: NIFI-10826 Separate Maven Compile and Verify in ci-workflow

Posted by GitBox <gi...@apache.org>.
mattyb149 commented on PR #6666:
URL: https://github.com/apache/nifi/pull/6666#issuecomment-1317428637

   +1 LGTM and all checks pass, thanks for the improvement! Merging to main


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org