You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/21 10:48:21 UTC
[GitHub] [airflow] RikHeijdens opened a new pull request #13215: Fix QueuedLocalWorker crashing with EOFError
RikHeijdens opened a new pull request #13215:
URL: https://github.com/apache/airflow/pull/13215
`LocalExecutor` uses a [multiprocessing.Queue](https://docs.python.org/3/library/multiprocessing.html#multiprocessing.Queue) to distribute tasks to the instances of `QueuedLocalWorker`. If for some reason LocalExecutor exits (e.g. because it encountered an unhandled exception), then each of the QueuedLocalWorker instances that it manages will also exit with an uncaught `EOFError` while trying to read from the task queue.
Because this causes a traceback to be logged for each of the workers that exits, this obfuscates the root cause of the issue, i.e. that the managing `LocalExecutor` terminated. By catching the `EOFError` in QueuedLocalWorker, logging an error and exiting gracefully we circumvent this problem, providing more clarity to the root cause of the issue to the Airflow administrator.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #13215: Fix QueuedLocalWorker crashing with EOFError
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #13215:
URL: https://github.com/apache/airflow/pull/13215
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13215: Fix QueuedLocalWorker crashing with EOFError
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13215:
URL: https://github.com/apache/airflow/pull/13215#issuecomment-749187278
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org