You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/03/30 15:19:05 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #4595: Set the
endpoint name length to 150, to keep safe and avoid over-length.
wu-sheng opened a new pull request #4595: Set the endpoint name length to 150, to keep safe and avoid over-length.
URL: https://github.com/apache/skywalking/pull/4595
This time, we set the very strict rule at the javaagent and OAP backend.
Especially, the OAP backend protects the storage.
`core/endpointNameMaxLength` = 150 as recommended. And comments as following
```yaml
core:
selector: ${SW_CORE:default}
default:
...
# The max length of the endpoint name.
# In the current practice, we don't recommend the length over 190.
endpointNameMaxLength: ${SW_CORE_ENDPOINT_NAME_MAX_LENGTH:150}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng commented on a change in pull request #4595:
Set the endpoint name length to 150, to keep safe and avoid over-length.
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #4595: Set the endpoint name length to 150, to keep safe and avoid over-length.
URL: https://github.com/apache/skywalking/pull/4595#discussion_r400285267
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EndpointRelation.java
##########
@@ -71,16 +75,19 @@ public String getEntityId() {
@ScopeDefaultColumn.DefinedByField(columnName = "child_service_id")
private int childServiceId;
@Getter
- @Setter
Review comment:
Yes. Added back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] wu-sheng merged pull request #4595: Set the endpoint
name length to 150, to keep safe and avoid over-length.
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #4595: Set the endpoint name length to 150, to keep safe and avoid over-length.
URL: https://github.com/apache/skywalking/pull/4595
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request
#4595: Set the endpoint name length to 150,
to keep safe and avoid over-length.
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #4595: Set the endpoint name length to 150, to keep safe and avoid over-length.
URL: https://github.com/apache/skywalking/pull/4595#discussion_r400283193
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/EndpointRelation.java
##########
@@ -71,16 +75,19 @@ public String getEntityId() {
@ScopeDefaultColumn.DefinedByField(columnName = "child_service_id")
private int childServiceId;
@Getter
- @Setter
Review comment:
This should be reverted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services