You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/12/09 19:59:53 UTC

[GitHub] [tvm] csullivan opened a new pull request #7073: Rollback changes to SSA begin/end scope for Store in C codegen

csullivan opened a new pull request #7073:
URL: https://github.com/apache/tvm/pull/7073


   Rollback changes to SSA begin/end scope for Store in C codegen. Instead, scope binary operator codegen in CUDA to fix the issue originally addressed by 5f4b9a9.
   
   Thanks for contributing to TVM!   Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen commented on pull request #7073: Rollback changes to SSA begin/end scope for Store in C codegen

Posted by GitBox <gi...@apache.org>.
tqchen commented on pull request #7073:
URL: https://github.com/apache/tvm/pull/7073#issuecomment-743355792


   Thanks @csullivan @merrymercy !


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] csullivan commented on pull request #7073: Rollback changes to SSA begin/end scope for Store in C codegen

Posted by GitBox <gi...@apache.org>.
csullivan commented on pull request #7073:
URL: https://github.com/apache/tvm/pull/7073#issuecomment-742797682


   Thank you. 
   Looks like main is failing the linter after a bad merge. @vegaluisjose fixes it here: https://github.com/apache/tvm/pull/7081/files


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] tqchen merged pull request #7073: Rollback changes to SSA begin/end scope for Store in C codegen

Posted by GitBox <gi...@apache.org>.
tqchen merged pull request #7073:
URL: https://github.com/apache/tvm/pull/7073


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [tvm] merrymercy commented on pull request #7073: Rollback changes to SSA begin/end scope for Store in C codegen

Posted by GitBox <gi...@apache.org>.
merrymercy commented on pull request #7073:
URL: https://github.com/apache/tvm/pull/7073#issuecomment-742775769


   LGTM. Please fix the lint error


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org