You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/02/02 09:52:00 UTC
[jira] [Work logged] (HADOOP-17497) refactoring the signature of
S3ClientFactory breaks hboss compile
[ https://issues.apache.org/jira/browse/HADOOP-17497?focusedWorklogId=545915&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-545915 ]
ASF GitHub Bot logged work on HADOOP-17497:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Feb/21 09:51
Start Date: 02/Feb/21 09:51
Worklog Time Spent: 10m
Work Description: mukund-thakur commented on a change in pull request #2654:
URL: https://github.com/apache/hadoop/pull/2654#discussion_r568463307
##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ClientFactory.java
##########
@@ -46,10 +49,32 @@
* @return S3 client
* @throws IOException IO problem
*/
- AmazonS3 createS3Client(URI name,
+ default AmazonS3 createS3Client(URI name,
String bucket,
AWSCredentialsProvider credentialSet,
String userAgentSuffix,
- StatisticsFromAwsSdk statisticsFromAwsSdk) throws IOException;
+ StatisticsFromAwsSdk statisticsFromAwsSdk) throws IOException {
+ return createS3Client(name, bucket, credentialSet, userAgentSuffix);
+ }
+
+ /**
+ * Creates a new {@link AmazonS3} client.
+ * Obsolete and never directly called in the s3 code.
+ * It exists to keep HBoss builds compiling: they do implement it
+ * and want to build/run across Hadoop versions.
+ * @param name raw input S3A file system URI
+ * @param bucket Optional bucket to use to look up per-bucket proxy secrets
+ * @param credentialSet credentials to use
+ * @param userAgentSuffix optional suffix for the UA field.
+ * @return S3 client
+ * @throws IOException IO problem
+ * @deprecated this is only here to stop hboss builds breaking.
+ */
+ default AmazonS3 createS3Client(URI name,
+ String bucket,
+ AWSCredentialsProvider credentialSet,
+ String userAgentSuffix) throws IOException {
+ throw new UnsupportedOperationException("Not implemented");
Review comment:
Builds will compile now but tests will still fail right?
##########
File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ClientFactory.java
##########
@@ -30,6 +30,9 @@
/**
* Factory for creation of {@link AmazonS3} client instances.
+ * Important: HBase's HBoss module implements this interface in its
+ * test. If changing the signature use default implementations to avoid
Review comment:
nit: doc seems a bit off. Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 545915)
Time Spent: 1h (was: 50m)
> refactoring the signature of S3ClientFactory breaks hboss compile
> -----------------------------------------------------------------
>
> Key: HADOOP-17497
> URL: https://issues.apache.org/jira/browse/HADOOP-17497
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.3.1
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> ...restore removed S3ClientFactory method and call it as default by new one
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org