You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "MarigWeizhi (via GitHub)" <gi...@apache.org> on 2025/07/31 18:15:38 UTC

[I] [Improvement]: Use data file format for delete file if not set [amoro]

MarigWeizhi opened a new issue, #3703:
URL: https://github.com/apache/amoro/issues/3703

   ### Search before asking
   
   - [x] I have searched in the [issues](https://github.com/apache/amoro/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### What would you like to be improved?
   
   The Iceberg community documentation indicates that if `write.delete.format.default` is not set, `write.format.default` will be used by default.   
   However, the current logic in Amoro is to use Parquet by default. We should align with Iceberg's logic so that users only need to set one parameter.
   <img width="1193" height="463" alt="Image" src="https://github.com/user-attachments/assets/8061796c-d19f-4932-9ece-a1159953a4f8" />
   
   <img width="1331" height="540" alt="Image" src="https://github.com/user-attachments/assets/5488d27e-97ed-4ba7-9ef1-2f1b787e14ef" />
   
   ### How should we improve?
   
   If the user has not set write.delete.format.default, we should use dataFileFormat
   
   ### Are you willing to submit PR?
   
   - [x] Yes I am willing to submit a PR!
   
   ### Subtasks
   
   _No response_
   
   ### Code of Conduct
   
   - [x] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Improvement]: Use data file format for delete file if not set [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong commented on issue #3703:
URL: https://github.com/apache/amoro/issues/3703#issuecomment-3141935557

   Yes, we should keep the same behavior with other engines like [Spark](https://github.com/apache/iceberg/blob/apache-iceberg-1.9.2/spark/v3.5/spark/src/main/java/org/apache/iceberg/spark/SparkWriteConf.java#L216).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] [Improvement]: Use data file format for delete file if not set [amoro]

Posted by "zhoujinsong (via GitHub)" <gi...@apache.org>.
zhoujinsong closed issue #3703: [Improvement]: Use data file format for delete file if not set
URL: https://github.com/apache/amoro/issues/3703


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org