[GitHub] [trafficserver] shinrich commented on issue #7705: Assertion in HttpCacheSM captive_action.cancelled == 0

[GitBox <gi...@apache.org>]

shinrich commented on issue #7705:
URL: https://github.com/apache/trafficserver/issues/7705#issuecomment-819024661


   Looks like the new PendingClass will cancel an action before setting it to nulllptr (clearing it).  Should be harmless for an action that has already executed (as it has on this stack frame 31/32).  
   
   ```
   PendingAction &
     operator=(Action *b)
     {
       // Don't do anything if the new action is _DONE
       if (b != ACTION_RESULT_DONE) {
         if (b != pending_action && pending_action != nullptr) {
           pending_action->cancel();
         }
         pending_action = b;
       }
       return *this;
     }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org