You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jclouds.apache.org by Andrew Phillips <no...@github.com> on 2014/02/05 10:30:27 UTC

[jclouds] Revert workaround for Guava issue 1635 (#281)

See [JCLOUDS-432](https://issues.apache.org/jira/browse/JCLOUDS-432) and [Guava 1635](https://code.google.com/p/guava-libraries/issues/detail?id=1635)
You can merge this Pull Request by running:

  git pull https://github.com/jclouds/jclouds revert-guava-fix

Or you can view, comment on it, or merge it online at:

  https://github.com/jclouds/jclouds/pull/281

-- Commit Summary --

  * Upgrading Guava 16.0 -&gt; 16.0.1
  * Revert &quot;JCLOUDS-427: Avoiding Guava reflection code broken in Java 7u51&quot;

-- File Changes --

    M core/pom.xml (2)
    M core/src/main/java/org/jclouds/internal/BaseView.java (15)
    M core/src/main/java/org/jclouds/rest/config/BinderUtils.java (17)
    M core/src/main/java/org/jclouds/rest/internal/BaseRestApiMetadata.java (9)
    D core/src/main/java/org/jclouds/util/TypeToken2.java (78)

-- Patch Links --

https://github.com/jclouds/jclouds/pull/281.patch
https://github.com/jclouds/jclouds/pull/281.diff

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Andrew Phillips <no...@github.com>.
Successful DEV@cloud run against 7u51:

https://jclouds.ci.cloudbees.com/job/jclouds-java-7u51/34/

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34150009

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Everett Toews <no...@github.com>.
@demobox This will be backported to 1.7.x correct?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34182220

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Andrew Phillips <no...@github.com>.
> I asked about a 15.0.1 release in the upstream Guava issue:

I saw that, thanks @andrewgaul! Curious to see if there'll be any response...

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34652502

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Andrew Phillips <no...@github.com>.
Committed to master: [#1](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=02615adc4f45799d07f61727167b65c87458f573), [#2](https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=commit;h=4c07702d29de64df45c11819c2cc9d725382b0c2).

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34643091

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-pull-requests #572](https://jclouds.ci.cloudbees.com/job/jclouds-pull-requests/572/) SUCCESS
This pull request looks good

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34156432

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Andrew Phillips <no...@github.com>.
Another verification build running against master [using 7u51](https://jclouds.ci.cloudbees.com/job/jclouds-java-7u51/36/console)

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34643210

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Andrew Phillips <no...@github.com>.
> jclouds-java-7-pull-requests #1044 UNSTABLE

Yet another timing-related [test failure](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/org.apache.jclouds$jclouds-compute/1044/testReport/junit/org.jclouds.compute.callables/BlockUntilInitScriptStatusIsZeroThenReturnOutputTest/testloopUntilTrueOrThrowCancellationExceptionReturnsWhenPredicateIsTrueSecondTimeWhileNotCancelled/). Unrelated to this PR.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34210495

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Andrew Phillips <no...@github.com>.
@abayer @nacx @andrewgaul: thoughts on merging this one?

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34431668

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Andrew Phillips <no...@github.com>.
> A final verification build running against master using 7u51
```
channel stopped
Finished: SUCCESS
```

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34662659

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Ignasi Barrera <no...@github.com>.
@demobox +1. Thanks!

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34621511

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Andrew Gaul <no...@github.com>.
I asked about a 15.0.1 release in the upstream Guava issue:

https://code.google.com/p/guava-libraries/issues/detail?id=1635#c45

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34651577

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by Andrew Phillips <no...@github.com>.
> @demobox This will be backported to 1.7.x correct?

I don't see how to, yet. The Guava team has not so far released a fix for Guava 15, and from what I know we were not planning to bump Guava versions in minor releases. So the current workaround for 1.7.x would have to stay in place.

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34209136

Re: [jclouds] Revert workaround for Guava issue 1635 (#281)

Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-java-7-pull-requests #1044](https://jclouds.ci.cloudbees.com/job/jclouds-java-7-pull-requests/1044/) UNSTABLE
Looks like there's a problem with this pull request

---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds/pull/281#issuecomment-34156874