[GitHub] [zookeeper] maoling commented on a change in pull request #1528: ZOOKEEPER-3982: export ZooKeeper version as prometheus metric

[GitBox <gi...@apache.org>]

maoling commented on a change in pull request #1528:
URL: https://github.com/apache/zookeeper/pull/1528#discussion_r669588617



##########
File path: zookeeper-metrics-providers/zookeeper-prometheus-metrics/src/main/java/org/apache/zookeeper/metrics/prometheus/PrometheusMetricsProvider.java
##########
@@ -70,6 +70,7 @@
     private Server server;
     private final MetricsServletImpl servlet = new MetricsServletImpl();
     private final Context rootContext = new Context();
+    public final CustomizedExports customizedExports = CustomizedExports.instance();

Review comment:
       I need to clean up customizedExports in the PrometheusMetricsProviderTest#setup manually because customizedExports is the text information which will pollute all the existing UTs in the PrometheusMetricsProviderTest




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org