You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/11/18 06:52:12 UTC

[GitHub] [bookkeeper] wenbingshen commented on a diff in pull request #3652: Add num not adhering placement ledgers replicated metric for ReplicationWorker

wenbingshen commented on code in PR #3652:
URL: https://github.com/apache/bookkeeper/pull/3652#discussion_r1026081606


##########
bookkeeper-server/src/test/java/org/apache/bookkeeper/replication/TestReplicationWorker.java:
##########
@@ -1262,6 +1268,9 @@ protected EnsemblePlacementPolicy initializeEnsemblePlacementPolicy(ClientConfig
             assertNull(stat1);
         });
 
+        assertTrue("NUM_NOT_ADHERING_PLACEMENT_LEDGERS_REPLICATED",

Review Comment:
   Good suggestion. I found a bug about numLedgersReplicated update. I have submit another PR #3654 to fix it. PTAL. I will update this PR when that PR is merged.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org