You are viewing a plain text version of this content. The canonical link for it is here.
Posted to slide-dev@jakarta.apache.org by Oliver Zeigermann <oz...@c1-fse.de> on 2004/07/15 15:53:38 UTC
PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
VersioningHelper.java
Please have a look at this very simple patch. I have set the display
name of the VHR to the displayname of the resource that gets versioned.
This makes it easier to find the versions of the resource in the history
folder with non-DeltaV-aware clients like the Windows Explorer as they
are no longer called '4711', but rahter 'Important.doc'. Please note
that this does not effect the path of the VHR, but only the displayname.
What do you folks say? Should we keep it this way or shall I undo my change?
Oliver
ozeigermann@apache.org wrote:
> ozeigermann 2004/07/15 06:46:21
>
> Modified: src/webdav/server/org/apache/slide/webdav/util
> VersioningHelper.java
> Log:
> Set the display name of the VHR to the name of the resource that gets
> versioned to make it a easier to find versions with clients
> that do not support DeltaV (like MS Explorer).
>
> Revision Changes Path
> 1.104 +5 -4 jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelper.java
>
> Index: VersioningHelper.java
> ===================================================================
> RCS file: /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelper.java,v
> retrieving revision 1.103
> retrieving revision 1.104
> diff -u -r1.103 -r1.104
> --- VersioningHelper.java 24 Jun 2004 13:18:52 -0000 1.103
> +++ VersioningHelper.java 15 Jul 2004 13:46:21 -0000 1.104
> @@ -328,7 +328,8 @@
> vhrNrd.setLastModified( new Date() ); // P_GETLASTMODIFIED
> vhrNrd.setContentLength( 0 ); // P_GETCONTENTLENGTH
> vhrNrd.setETag( PropertyHelper.computeEtag(vhrUri, vhrNrd) ); // P_GETETAG
> - vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
> +// vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
> + vhrNrd.setName( rNrd.getName() ); // P_DISPLAYNAME
> vhrNrd.setProperty(
> new NodeProperty(P_VERSION_SET, pHelp.createHrefValue(vrUri)) );
> vrNrd.setCreationDate( new Date() ); // P_CREATIONDATE
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
VersioningHelper.java
Posted by Oliver Zeigermann <ol...@zeigermann.de>.
Oliver Zeigermann wrote:
> Martin Holz wrote:
>
>> Oliver Zeigermann <oz...@c1-fse.de> writes:
>>
>>
>>> Please have a look at this very simple patch. I have set the display
>>> name of the VHR to the displayname of the resource that gets
>>> versioned. This makes it easier to find the versions of the resource
>>> in the history folder with non-DeltaV-aware clients like the Windows
>>> Explorer as they are no longer called '4711', but rahter
>>> 'Important.doc'. Please note that this does not effect the path of the
>>> VHR, but only the displayname.
>>
>>
>>
>> What happens, if there is a branch and displaynames in both branches
>> are different? Whatever is checked in later wins?
>
>
> Yes. My tiny patch is only to be considered a hint for the small scale
> user. He/she may have only a few files flying around and no DeltaV-aware
> client. The displayname is merely a hint to have a reference to where
> versiones can be found. It is also less effective if we enable your
> patch for smaller collection sizes as only the last part of the path
> will be named after the resource.
>
> I just though it does not do any harm in large scale scenarios, but may
> be useful in small scale ones.
Ah sorry, the answer is 'no'. The displayname is set upon creation of
the VHR, so it is set as soon as the resource is put under version control.
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
VersioningHelper.java
Posted by Oliver Zeigermann <ol...@zeigermann.de>.
Martin Holz wrote:
> Oliver Zeigermann <oz...@c1-fse.de> writes:
>
>
>>Please have a look at this very simple patch. I have set the display
>>name of the VHR to the displayname of the resource that gets
>>versioned. This makes it easier to find the versions of the resource
>>in the history folder with non-DeltaV-aware clients like the Windows
>>Explorer as they are no longer called '4711', but rahter
>>'Important.doc'. Please note that this does not effect the path of the
>>VHR, but only the displayname.
>
>
> What happens, if there is a branch and displaynames in both branches
> are different? Whatever is checked in later wins?
Yes. My tiny patch is only to be considered a hint for the small scale
user. He/she may have only a few files flying around and no DeltaV-aware
client. The displayname is merely a hint to have a reference to where
versiones can be found. It is also less effective if we enable your
patch for smaller collection sizes as only the last part of the path
will be named after the resource.
I just though it does not do any harm in large scale scenarios, but may
be useful in small scale ones.
Oliver
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util VersioningHelper.java
Posted by Martin Holz <ho...@fiz-chemie.de>.
Oliver Zeigermann <oz...@c1-fse.de> writes:
> Please have a look at this very simple patch. I have set the display
> name of the VHR to the displayname of the resource that gets
> versioned. This makes it easier to find the versions of the resource
> in the history folder with non-DeltaV-aware clients like the Windows
> Explorer as they are no longer called '4711', but rahter
> 'Important.doc'. Please note that this does not effect the path of the
> VHR, but only the displayname.
What happens, if there is a branch and displaynames in both branches
are different? Whatever is checked in later wins?
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
VersioningHelper.java
Posted by Oliver Zeigermann <oz...@c1-fse.de>.
With useHistoryCollectionHack the history folder might look like this:
- 1
|
-- Einkaufsliste.doc (VHR collection)
|
-- Unterschlagung.doc (VHR collection)
|
-- Kündigung.doc (VHR collection)
- 2
|
-- ...
|
-- ...
Oliver
Stefan Lützkendorf wrote:
> How does this correspond to the useHistoryCollectionHack?
>
> Stefan
>
> Oliver Zeigermann wrote:
>
>> Please have a look at this very simple patch. I have set the display
>> name of the VHR to the displayname of the resource that gets
>> versioned. This makes it easier to find the versions of the resource
>> in the history folder with non-DeltaV-aware clients like the Windows
>> Explorer as they are no longer called '4711', but rahter
>> 'Important.doc'. Please note that this does not effect the path of the
>> VHR, but only the displayname.
>>
>> What do you folks say? Should we keep it this way or shall I undo my
>> change?
>>
>> Oliver
>>
>> ozeigermann@apache.org wrote:
>>
>>> ozeigermann 2004/07/15 06:46:21
>>>
>>> Modified: src/webdav/server/org/apache/slide/webdav/util
>>> VersioningHelper.java
>>> Log:
>>> Set the display name of the VHR to the name of the resource that gets
>>> versioned to make it a easier to find versions with clients
>>> that do not support DeltaV (like MS Explorer).
>>> Revision Changes Path
>>> 1.104 +5 -4
>>> jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelper.java
>>>
>>> Index: VersioningHelper.java
>>> ===================================================================
>>> RCS file:
>>> /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelper.java,v
>>>
>>> retrieving revision 1.103
>>> retrieving revision 1.104
>>> diff -u -r1.103 -r1.104
>>> --- VersioningHelper.java 24 Jun 2004 13:18:52 -0000 1.103
>>> +++ VersioningHelper.java 15 Jul 2004 13:46:21 -0000 1.104
>>> @@ -328,7 +328,8 @@
>>> vhrNrd.setLastModified( new Date() ); // P_GETLASTMODIFIED
>>> vhrNrd.setContentLength( 0 ); // P_GETCONTENTLENGTH
>>> vhrNrd.setETag( PropertyHelper.computeEtag(vhrUri, vhrNrd)
>>> ); // P_GETETAG
>>> - vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
>>> +// vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
>>> + vhrNrd.setName( rNrd.getName() ); // P_DISPLAYNAME
>>> vhrNrd.setProperty(
>>> new NodeProperty(P_VERSION_SET,
>>> pHelp.createHrefValue(vrUri)) );
>>> vrNrd.setCreationDate( new Date() ); // P_CREATIONDATE
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
>>> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
VersioningHelper.java
Posted by Stefan Lützkendorf <lu...@apache.org>.
How does this correspond to the useHistoryCollectionHack?
Stefan
Oliver Zeigermann wrote:
> Please have a look at this very simple patch. I have set the display
> name of the VHR to the displayname of the resource that gets versioned.
> This makes it easier to find the versions of the resource in the history
> folder with non-DeltaV-aware clients like the Windows Explorer as they
> are no longer called '4711', but rahter 'Important.doc'. Please note
> that this does not effect the path of the VHR, but only the displayname.
>
> What do you folks say? Should we keep it this way or shall I undo my
> change?
>
> Oliver
>
> ozeigermann@apache.org wrote:
>
>> ozeigermann 2004/07/15 06:46:21
>>
>> Modified: src/webdav/server/org/apache/slide/webdav/util
>> VersioningHelper.java
>> Log:
>> Set the display name of the VHR to the name of the resource that gets
>> versioned to make it a easier to find versions with clients
>> that do not support DeltaV (like MS Explorer).
>> Revision Changes Path
>> 1.104 +5 -4
>> jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelper.java
>>
>> Index: VersioningHelper.java
>> ===================================================================
>> RCS file:
>> /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelper.java,v
>>
>> retrieving revision 1.103
>> retrieving revision 1.104
>> diff -u -r1.103 -r1.104
>> --- VersioningHelper.java 24 Jun 2004 13:18:52 -0000 1.103
>> +++ VersioningHelper.java 15 Jul 2004 13:46:21 -0000 1.104
>> @@ -328,7 +328,8 @@
>> vhrNrd.setLastModified( new Date() ); // P_GETLASTMODIFIED
>> vhrNrd.setContentLength( 0 ); // P_GETCONTENTLENGTH
>> vhrNrd.setETag( PropertyHelper.computeEtag(vhrUri, vhrNrd)
>> ); // P_GETETAG
>> - vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
>> +// vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
>> + vhrNrd.setName( rNrd.getName() ); // P_DISPLAYNAME
>> vhrNrd.setProperty(
>> new NodeProperty(P_VERSION_SET,
>> pHelp.createHrefValue(vrUri)) );
>> vrNrd.setCreationDate( new Date() ); // P_CREATIONDATE
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
>> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util VersioningHelper.java
Posted by Martin Holz <ho...@fiz-chemie.de>.
Oliver Zeigermann <oz...@c1-fse.de> writes:
> Please have a look at this very simple patch. I have set the display
> name of the VHR to the displayname of the resource that gets
> versioned. This makes it easier to find the versions of the resource
> in the history folder with non-DeltaV-aware clients like the Windows
> Explorer as they are no longer called '4711', but rahter
> 'Important.doc'. Please note that this does not effect the path of the
> VHR, but only the displayname.
>
>
> What do you folks say? Should we keep it this way or shall I undo my change?
I expect some trouble with broken clients. If there is more than one
resource with the same displayname, e.g. index.html, probably only
one document is shown. My current MS Explorer (msdaipp.dll 8.103.5219.0)
ignores the displayname completely. Also there might be inconsistencies,
if a resource moves. Nevertheless I like the idea.
+1 for keeping it.
Martin
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util VersioningHelper.java
Posted by Jacob Lund <jl...@qualiware.net>.
ahh beautiful :-)
+1
Jacob
----- Original Message -----
From: "Oliver Zeigermann" <ol...@zeigermann.de>
To: "Slide Developers Mailing List" <sl...@jakarta.apache.org>
Sent: Friday, July 16, 2004 11:02 AM
Subject: Re: PLEASE REVIEW / WAS cvs commit:
jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
VersioningHelper.java
> Nono, quite different. Only talking about VHRs you find in the /history
> folder. Your folder will look like
>
> 1
> 2
> 3
>
> but mine looks like
>
> Important.doc
> Proposal.doc
> Einkaufsliste.doc
>
> The versioned resources are *inside* these collections and are not
> effected at all.
>
> Oliver
>
> Jacob Lund wrote:
>
> > I am not sure if I understand this correctly.
> >
> > If I change the displayname of a resource and then do a checkin then the
> > value of displayname will be overwritten with the name of the resource?
If
> > so then displayname should be a protected property since displayname no
> > longer will be versionable.
> >
> > If this is the case then this feature should be a setting in the
domain.xml.
> >
> > /jacob
> >
> > ----- Original Message -----
> > From: "Oliver Zeigermann" <oz...@c1-fse.de>
> > To: "Slide Developers Mailing List" <sl...@jakarta.apache.org>
> > Sent: Thursday, July 15, 2004 3:53 PM
> > Subject: PLEASE REVIEW / WAS cvs commit:
> > jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
> > VersioningHelper.java
> >
> >
> >
> >>Please have a look at this very simple patch. I have set the display
> >>name of the VHR to the displayname of the resource that gets versioned.
> >>This makes it easier to find the versions of the resource in the history
> >>folder with non-DeltaV-aware clients like the Windows Explorer as they
> >>are no longer called '4711', but rahter 'Important.doc'. Please note
> >>that this does not effect the path of the VHR, but only the displayname.
> >>
> >>What do you folks say? Should we keep it this way or shall I undo my
> >
> > change?
> >
> >>Oliver
> >>
> >>ozeigermann@apache.org wrote:
> >>
> >>
> >>>ozeigermann 2004/07/15 06:46:21
> >>>
> >>> Modified: src/webdav/server/org/apache/slide/webdav/util
> >>> VersioningHelper.java
> >>> Log:
> >>> Set the display name of the VHR to the name of the resource that gets
> >>> versioned to make it a easier to find versions with clients
> >>> that do not support DeltaV (like MS Explorer).
> >>>
> >>> Revision Changes Path
> >>> 1.104 +5 -4
> >
> >
jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelpe
> > r.java
> >
> >>> Index: VersioningHelper.java
> >>> ===================================================================
> >>> RCS file:
> >
> >
/home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/Versi
> > oningHelper.java,v
> >
> >>> retrieving revision 1.103
> >>> retrieving revision 1.104
> >>> diff -u -r1.103 -r1.104
> >>> --- VersioningHelper.java 24 Jun 2004 13:18:52 -0000 1.103
> >>> +++ VersioningHelper.java 15 Jul 2004 13:46:21 -0000 1.104
> >>> @@ -328,7 +328,8 @@
> >>> vhrNrd.setLastModified( new Date() ); // P_GETLASTMODIFIED
> >>> vhrNrd.setContentLength( 0 ); // P_GETCONTENTLENGTH
> >>> vhrNrd.setETag( PropertyHelper.computeEtag(vhrUri,
vhrNrd) );
> >
> > // P_GETETAG
> >
> >>> - vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
> >>> +// vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
> >>> + vhrNrd.setName( rNrd.getName() ); // P_DISPLAYNAME
> >>> vhrNrd.setProperty(
> >>> new NodeProperty(P_VERSION_SET,
> >
> > pHelp.createHrefValue(vrUri)) );
> >
> >>> vrNrd.setCreationDate( new Date() ); // P_CREATIONDATE
> >>>
> >>>
> >>>
> >>>
> >>>---------------------------------------------------------------------
> >>>To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> >>>For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> >>>
> >>
> >>
> >>---------------------------------------------------------------------
> >>To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> >>For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> >>
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
VersioningHelper.java
Posted by Oliver Zeigermann <ol...@zeigermann.de>.
Nono, quite different. Only talking about VHRs you find in the /history
folder. Your folder will look like
1
2
3
but mine looks like
Important.doc
Proposal.doc
Einkaufsliste.doc
The versioned resources are *inside* these collections and are not
effected at all.
Oliver
Jacob Lund wrote:
> I am not sure if I understand this correctly.
>
> If I change the displayname of a resource and then do a checkin then the
> value of displayname will be overwritten with the name of the resource? If
> so then displayname should be a protected property since displayname no
> longer will be versionable.
>
> If this is the case then this feature should be a setting in the domain.xml.
>
> /jacob
>
> ----- Original Message -----
> From: "Oliver Zeigermann" <oz...@c1-fse.de>
> To: "Slide Developers Mailing List" <sl...@jakarta.apache.org>
> Sent: Thursday, July 15, 2004 3:53 PM
> Subject: PLEASE REVIEW / WAS cvs commit:
> jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
> VersioningHelper.java
>
>
>
>>Please have a look at this very simple patch. I have set the display
>>name of the VHR to the displayname of the resource that gets versioned.
>>This makes it easier to find the versions of the resource in the history
>>folder with non-DeltaV-aware clients like the Windows Explorer as they
>>are no longer called '4711', but rahter 'Important.doc'. Please note
>>that this does not effect the path of the VHR, but only the displayname.
>>
>>What do you folks say? Should we keep it this way or shall I undo my
>
> change?
>
>>Oliver
>>
>>ozeigermann@apache.org wrote:
>>
>>
>>>ozeigermann 2004/07/15 06:46:21
>>>
>>> Modified: src/webdav/server/org/apache/slide/webdav/util
>>> VersioningHelper.java
>>> Log:
>>> Set the display name of the VHR to the name of the resource that gets
>>> versioned to make it a easier to find versions with clients
>>> that do not support DeltaV (like MS Explorer).
>>>
>>> Revision Changes Path
>>> 1.104 +5 -4
>
> jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelpe
> r.java
>
>>> Index: VersioningHelper.java
>>> ===================================================================
>>> RCS file:
>
> /home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/Versi
> oningHelper.java,v
>
>>> retrieving revision 1.103
>>> retrieving revision 1.104
>>> diff -u -r1.103 -r1.104
>>> --- VersioningHelper.java 24 Jun 2004 13:18:52 -0000 1.103
>>> +++ VersioningHelper.java 15 Jul 2004 13:46:21 -0000 1.104
>>> @@ -328,7 +328,8 @@
>>> vhrNrd.setLastModified( new Date() ); // P_GETLASTMODIFIED
>>> vhrNrd.setContentLength( 0 ); // P_GETCONTENTLENGTH
>>> vhrNrd.setETag( PropertyHelper.computeEtag(vhrUri, vhrNrd) );
>
> // P_GETETAG
>
>>> - vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
>>> +// vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
>>> + vhrNrd.setName( rNrd.getName() ); // P_DISPLAYNAME
>>> vhrNrd.setProperty(
>>> new NodeProperty(P_VERSION_SET,
>
> pHelp.createHrefValue(vrUri)) );
>
>>> vrNrd.setCreationDate( new Date() ); // P_CREATIONDATE
>>>
>>>
>>>
>>>
>>>---------------------------------------------------------------------
>>>To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
>>>For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>>>
>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
>>For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util VersioningHelper.java
Posted by Martin Holz <ho...@fiz-chemie.de>.
"Jacob Lund" <jl...@qualiware.net> writes:
> I am not sure if I understand this correctly.
>
> If I change the displayname of a resource and then do a checkin then the
> value of displayname will be overwritten with the name of the resource? If
> so then displayname should be a protected property since displayname no
> longer will be versionable.
No. There is a Version-Controlled resource at /files/foo.html All versions
of this resource exist inside a collection /history/1234. You could
find the version 1.2 of /files/foo.html at /history/1234/1.2.
Now Oliver proposes to set the displayname of
/history/1234 to foo.html. The displayname of /history/1234/1.2
would be whatever it was for /files/foo.html, when it was checked in.
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org
Re: PLEASE REVIEW / WAS cvs commit: jakarta-slide/src/webdav/server/org/apache/slide/webdav/util VersioningHelper.java
Posted by Jacob Lund <jl...@qualiware.net>.
I am not sure if I understand this correctly.
If I change the displayname of a resource and then do a checkin then the
value of displayname will be overwritten with the name of the resource? If
so then displayname should be a protected property since displayname no
longer will be versionable.
If this is the case then this feature should be a setting in the domain.xml.
/jacob
----- Original Message -----
From: "Oliver Zeigermann" <oz...@c1-fse.de>
To: "Slide Developers Mailing List" <sl...@jakarta.apache.org>
Sent: Thursday, July 15, 2004 3:53 PM
Subject: PLEASE REVIEW / WAS cvs commit:
jakarta-slide/src/webdav/server/org/apache/slide/webdav/util
VersioningHelper.java
> Please have a look at this very simple patch. I have set the display
> name of the VHR to the displayname of the resource that gets versioned.
> This makes it easier to find the versions of the resource in the history
> folder with non-DeltaV-aware clients like the Windows Explorer as they
> are no longer called '4711', but rahter 'Important.doc'. Please note
> that this does not effect the path of the VHR, but only the displayname.
>
> What do you folks say? Should we keep it this way or shall I undo my
change?
>
> Oliver
>
> ozeigermann@apache.org wrote:
>
> > ozeigermann 2004/07/15 06:46:21
> >
> > Modified: src/webdav/server/org/apache/slide/webdav/util
> > VersioningHelper.java
> > Log:
> > Set the display name of the VHR to the name of the resource that gets
> > versioned to make it a easier to find versions with clients
> > that do not support DeltaV (like MS Explorer).
> >
> > Revision Changes Path
> > 1.104 +5 -4
jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/VersioningHelpe
r.java
> >
> > Index: VersioningHelper.java
> > ===================================================================
> > RCS file:
/home/cvs/jakarta-slide/src/webdav/server/org/apache/slide/webdav/util/Versi
oningHelper.java,v
> > retrieving revision 1.103
> > retrieving revision 1.104
> > diff -u -r1.103 -r1.104
> > --- VersioningHelper.java 24 Jun 2004 13:18:52 -0000 1.103
> > +++ VersioningHelper.java 15 Jul 2004 13:46:21 -0000 1.104
> > @@ -328,7 +328,8 @@
> > vhrNrd.setLastModified( new Date() ); // P_GETLASTMODIFIED
> > vhrNrd.setContentLength( 0 ); // P_GETCONTENTLENGTH
> > vhrNrd.setETag( PropertyHelper.computeEtag(vhrUri, vhrNrd) );
// P_GETETAG
> > - vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
> > +// vhrNrd.setName( vhrUh.getHistoryName() ); // P_DISPLAYNAME
> > + vhrNrd.setName( rNrd.getName() ); // P_DISPLAYNAME
> > vhrNrd.setProperty(
> > new NodeProperty(P_VERSION_SET,
pHelp.createHrefValue(vrUri)) );
> > vrNrd.setCreationDate( new Date() ); // P_CREATIONDATE
> >
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> > For additional commands, e-mail: slide-dev-help@jakarta.apache.org
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
> For additional commands, e-mail: slide-dev-help@jakarta.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: slide-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: slide-dev-help@jakarta.apache.org