You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2016/12/17 02:57:05 UTC
[kudu-CR] csd: add another path for KUDU HOME
Hello Jean-Daniel Cryans, Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5539
to review the following change.
Change subject: csd: add another path for KUDU_HOME
......................................................................
csd: add another path for KUDU_HOME
Kudu is provided in the CDH parcel in some new versions of CDH, and the
convention is for the CDH parcel to communicate component locations via
CDH_COMPONENT_HOME, not COMPONENT_HOME.
Change-Id: I4aa80a99ce2a368086f8c4988fa15056c755ab9f
---
M java/kudu-csd/src/scripts/kudu.sh
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/39/5539/1
--
To view, visit http://gerrit.cloudera.org:8080/5539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4aa80a99ce2a368086f8c4988fa15056c755ab9f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] csd: add another path for KUDU HOME
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: csd: add another path for KUDU_HOME
......................................................................
csd: add another path for KUDU_HOME
Kudu is provided in the CDH parcel in some new versions of CDH, and the
convention is for the CDH parcel to communicate component locations via
CDH_COMPONENT_HOME, not COMPONENT_HOME.
Change-Id: I4aa80a99ce2a368086f8c4988fa15056c755ab9f
Reviewed-on: http://gerrit.cloudera.org:8080/5539
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M java/kudu-csd/src/scripts/kudu.sh
1 file changed, 7 insertions(+), 1 deletion(-)
Approvals:
Todd Lipcon: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4aa80a99ce2a368086f8c4988fa15056c755ab9f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] csd: add another path for KUDU HOME
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: csd: add another path for KUDU_HOME
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5539
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4aa80a99ce2a368086f8c4988fa15056c755ab9f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jd...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No