[GitHub] [flink] Zakelly commented on a change in pull request #16510: [FLINK-23342][state] State ownership: compute shared state on recovery

[GitBox <gi...@apache.org>]

Zakelly commented on a change in pull request #16510:
URL: https://github.com/apache/flink/pull/16510#discussion_r676453816



##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/RetrievableStreamStateHandle.java
##########
@@ -85,4 +90,10 @@ public long getStateSize() {
     public void close() throws IOException {
         //		wrappedStreamStateHandle.close();
     }
+
+    @Override
+    public <E extends Exception> void accept(StateObjectVisitor<E> visitor) throws E {
+        wrappedStreamStateHandle.accept(visitor);
+        visitor.visit(this);

Review comment:
       I wonder whether we should visit this wrapper, after the wrapped handle has applied the visitor.

##########
File path: flink-runtime/src/main/java/org/apache/flink/runtime/state/SnapshotResult.java
##########
@@ -116,6 +116,14 @@ public long getStateSize() {
         return jobManagerOwnedSnapshot != null ? jobManagerOwnedSnapshot.getStateSize() : 0L;
     }
 
+    @Override
+    public <E extends Exception> void accept(StateObjectVisitor<E> visitor) throws E {
+        if (jobManagerOwnedSnapshot != null) {
+            jobManagerOwnedSnapshot.accept(visitor);
+        }

Review comment:
       Should the ```taskLocalSnapshot``` do ```.accept(visitor)``` as well?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org