[GitHub] [activemq-artemis] clebertsuconic commented on a change in pull request #2759: ARTEMIS-2408 Too many opened FDs after server stops

[GitBox <gi...@apache.org>]

clebertsuconic commented on a change in pull request #2759: ARTEMIS-2408 Too many opened FDs after server stops
URL: https://github.com/apache/activemq-artemis/pull/2759#discussion_r309738512
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java
 ##########
 @@ -1269,6 +1269,8 @@ void stop(boolean failoverOnServerShutdown, final boolean criticalIOError, boole
          this.analyzer = null;
       }
 
+      activateCallbacks.clear();
 
 Review comment:
   I see now. .the issue is that a stop(shutdown=true) should clear the activateCallbacks. 
   
   this is not really an issue when running on a real server, but if you call shutdown=true, it means the VM is going down and the process should cleanup anything left behind.
   
   As the callback is leaking, if you reused the server after a stop(shutdown=true) on the testsuite, you will have the activation (on this case the one holding the lock) being called an extra time, what would then cause the file leak.
   
   
   I will send another PR with checking the shutdown clause and add a test to avoid a future leak.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services