[GitHub] [accumulo] ctubbsii commented on pull request #2717: Create Public API to set multiple properties

[GitBox <gi...@apache.org>]

ctubbsii commented on PR #2717:
URL: https://github.com/apache/accumulo/pull/2717#issuecomment-1133439498

   > Maybe I'm missing something - but if setProperties replaces all properties except the ones set, someone would need to include multiple properties that are set by default. For the metadata table, that is 28 properties, for a user table, there are 7.
   
   The idea was that you've now empowered the user to read the existing properties, keep all, none, or some of the ones they want, do any updates on the client side, and then atomically set the result. It's a very simple, primitive API that enables the user to do whatever they want. Yes, if they want to keep any default ones, they would have to explicitly preserve those. But, it's not like the number of these is a problem... you can do this programmatically pretty trivially:
   
   ```java
   client.setProperties(changeHoweverIWant(readCurrentProps()));
   ```
   
   To make this explicit, the API interface could be:
   
   ```java
   void setProperties(Function<Map<String,String>,Map<String,String>> oldPropsToNewProps);
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org