You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "XN137 (via GitHub)" <gi...@apache.org> on 2025/05/27 13:32:40 UTC

[PR] fix credentials getting printed twice [polaris]

XN137 opened a new pull request, #1682:
URL: https://github.com/apache/polaris/pull/1682

   after https://github.com/apache/polaris/pull/1376 a comment shows that non-root credentials could get printed twice:
   ```
   2025-05-07 23:40:06,767 INFO  [org.apa.pol.ser.qua.con.QuarkusProducers] [,] [,,,] (Quarkus Main Thread) Bootstrapping realm(s) 'POLARIS', if necessary, from root credentials set provided via the environment variable POLARIS_BOOTSTRAP_CREDENTIALS or Java system property polaris.bootstrap.credentials ...
   realm: POLARIS root principal credentials: c15135cbf0977e3d:a38976b705f0959e0017e0cef831122e
   2025-05-07 23:40:06,819 INFO  [org.apa.pol.ser.qua.con.QuarkusProducers] [,] [,,,] (Quarkus Main Thread) Realm 'POLARIS' automatically bootstrapped, credentials were not present in root credentials set provided via the environment variable POLARIS_BOOTSTRAP_CREDENTIALS or Java system property polaris.bootstrap.credentials, see separate message printed to stdout.
   realm: POLARIS root principal credentials: c15135cbf0977e3d:a38976b705f0959e0017e0cef831122e
   ```
   
   so we remove all logging/printing from the `bootstrapRealms` implementations as the outer callers `QuarkusProducers.maybeBootstrap` and `BootstrapCommand.call` are already taking care of that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix credentials getting printed twice [polaris]

Posted by "XN137 (via GitHub)" <gi...@apache.org>.
XN137 commented on PR #1682:
URL: https://github.com/apache/polaris/pull/1682#issuecomment-2912594464

   wondering about this code:
   https://github.com/apache/polaris/blob/818cd007121515188b83794eca6327d97e423c56/quarkus/admin/src/main/java/org/apache/polaris/admintool/BootstrapCommand.java#L115-L124
   whether it should also only print credentials that were not taken from the root credentials as is done by [QuarkusProduers.maybeBootstrap](https://github.com/apache/polaris/blob/2e373e51ce5434c26635535b684ff210a53b1745/quarkus/service/src/main/java/org/apache/polaris/service/quarkus/config/QuarkusProducers.java#L201-L227)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix credentials getting printed twice [polaris]

Posted by "XN137 (via GitHub)" <gi...@apache.org>.
XN137 commented on code in PR #1682:
URL: https://github.com/apache/polaris/pull/1682#discussion_r2109219691


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -113,12 +113,12 @@ public synchronized Map<String, PrincipalSecretsResult> bootstrapRealms(
 
     for (String realm : realms) {
       RealmContext realmContext = () -> realm;
-      if (!metaStoreManagerMap.containsKey(realmContext.getRealmIdentifier())) {
+      if (!metaStoreManagerMap.containsKey(realm)) {

Review Comment:
   decided to refactor this for clarity as the `realmContext` is built from `realm` right above



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix credentials getting printed twice [polaris]

Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on PR #1682:
URL: https://github.com/apache/polaris/pull/1682#issuecomment-2915112479

   Thanks @XN137 for the fix. Thanks everyone for the review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix credentials getting printed twice [polaris]

Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain merged PR #1682:
URL: https://github.com/apache/polaris/pull/1682


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org