You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2023/11/03 13:15:56 UTC
(commons-bcel) branch master updated: Normalize test method names
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-bcel.git
The following commit(s) were added to refs/heads/master by this push:
new cdf228a6 Normalize test method names
cdf228a6 is described below
commit cdf228a643dbd7aae962cec58dc4dfea87021cd9
Author: Gary David Gregory (Code signing key) <gg...@apache.org>
AuthorDate: Fri Nov 3 09:15:50 2023 -0400
Normalize test method names
Sort test members
---
src/main/java/org/apache/bcel/generic/Type.java | 36 +++++++-------
src/test/java/org/apache/bcel/BCELBenchmark.java | 56 +++++++++++-----------
.../apache/bcel/generic/BREAKPOINTTestCase.java | 2 +-
.../java/org/apache/bcel/generic/D2FTestCase.java | 2 +-
.../java/org/apache/bcel/generic/D2ITestCase.java | 2 +-
.../java/org/apache/bcel/generic/D2LTestCase.java | 2 +-
.../java/org/apache/bcel/generic/DADDTestCase.java | 2 +-
.../java/org/apache/bcel/generic/DDIVTestCase.java | 2 +-
.../java/org/apache/bcel/generic/DMULTestCase.java | 2 +-
.../java/org/apache/bcel/generic/DNEGTestCase.java | 2 +-
.../java/org/apache/bcel/generic/DREMTestCase.java | 2 +-
.../java/org/apache/bcel/generic/DSUBTestCase.java | 2 +-
.../java/org/apache/bcel/generic/F2DTestCase.java | 2 +-
.../java/org/apache/bcel/generic/F2ITestCase.java | 2 +-
.../java/org/apache/bcel/generic/F2LTestCase.java | 2 +-
.../java/org/apache/bcel/generic/FADDTestCase.java | 2 +-
.../java/org/apache/bcel/generic/FDIVTestCase.java | 2 +-
.../java/org/apache/bcel/generic/FMULTestCase.java | 2 +-
.../java/org/apache/bcel/generic/FNEGTestCase.java | 2 +-
.../java/org/apache/bcel/generic/FREMTestCase.java | 2 +-
.../java/org/apache/bcel/generic/FSUBTestCase.java | 2 +-
.../org/apache/bcel/generic/GETFIELDTestCase.java | 2 +-
.../java/org/apache/bcel/generic/I2BTestCase.java | 2 +-
.../java/org/apache/bcel/generic/I2CTestCase.java | 2 +-
.../java/org/apache/bcel/generic/I2DTestCase.java | 2 +-
.../java/org/apache/bcel/generic/I2FTestCase.java | 2 +-
.../java/org/apache/bcel/generic/I2LTestCase.java | 2 +-
.../java/org/apache/bcel/generic/I2STestCase.java | 2 +-
.../java/org/apache/bcel/generic/IADDTestCase.java | 2 +-
.../java/org/apache/bcel/generic/IANDTestCase.java | 2 +-
.../java/org/apache/bcel/generic/IDIVTestCase.java | 2 +-
.../org/apache/bcel/generic/IMPDEP1TestCase.java | 2 +-
.../org/apache/bcel/generic/IMPDEP2TestCase.java | 2 +-
.../java/org/apache/bcel/generic/IMULTestCase.java | 2 +-
.../java/org/apache/bcel/generic/INEGTestCase.java | 2 +-
.../java/org/apache/bcel/generic/IORTestCase.java | 2 +-
.../java/org/apache/bcel/generic/IREMTestCase.java | 2 +-
.../java/org/apache/bcel/generic/ISHLTestCase.java | 2 +-
.../java/org/apache/bcel/generic/ISHRTestCase.java | 2 +-
.../java/org/apache/bcel/generic/ISUBTestCase.java | 2 +-
.../java/org/apache/bcel/generic/IXORTestCase.java | 2 +-
.../java/org/apache/bcel/generic/L2DTestCase.java | 2 +-
.../java/org/apache/bcel/generic/L2FTestCase.java | 2 +-
.../java/org/apache/bcel/generic/L2ITestCase.java | 2 +-
.../java/org/apache/bcel/generic/LADDTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LANDTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LCMPTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LDIVTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LMULTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LNEGTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LORTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LREMTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LSHLTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LSHRTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LSUBTestCase.java | 2 +-
.../java/org/apache/bcel/generic/LXORTestCase.java | 2 +-
.../org/apache/bcel/generic/PUTFIELDTestCase.java | 2 +-
.../org/apache/bcel/generic/PUTSTATICTestCase.java | 2 +-
.../java/org/apache/bcel/generic/TypeTestCase.java | 24 +++++-----
59 files changed, 114 insertions(+), 114 deletions(-)
diff --git a/src/main/java/org/apache/bcel/generic/Type.java b/src/main/java/org/apache/bcel/generic/Type.java
index f5e9c5ea..0ff9c80f 100644
--- a/src/main/java/org/apache/bcel/generic/Type.java
+++ b/src/main/java/org/apache/bcel/generic/Type.java
@@ -284,6 +284,24 @@ public abstract class Type {
return encode(1, index + 1);
}
+ static String internalTypeNameToSignature(final String internalTypeName) {
+ if (StringUtils.isEmpty(internalTypeName) || StringUtils.equalsAny(internalTypeName, Const.SHORT_TYPE_NAMES)) {
+ return internalTypeName;
+ }
+ switch (internalTypeName.charAt(0)) {
+ case '[':
+ return internalTypeName;
+ case 'L':
+ case 'T':
+ if (internalTypeName.charAt(internalTypeName.length() - 1) == ';') {
+ return internalTypeName;
+ }
+ return 'L' + internalTypeName + ';';
+ default:
+ return 'L' + internalTypeName + ';';
+ }
+ }
+
static int size(final int coded) {
return coded & 3;
}
@@ -366,24 +384,6 @@ public abstract class Type {
return type ^ signature.hashCode();
}
- static String internalTypeNameToSignature(final String internalTypeName) {
- if (StringUtils.isEmpty(internalTypeName) || StringUtils.equalsAny(internalTypeName, Const.SHORT_TYPE_NAMES)) {
- return internalTypeName;
- }
- switch (internalTypeName.charAt(0)) {
- case '[':
- return internalTypeName;
- case 'L':
- case 'T':
- if (internalTypeName.charAt(internalTypeName.length() - 1) == ';') {
- return internalTypeName;
- }
- return 'L' + internalTypeName + ';';
- default:
- return 'L' + internalTypeName + ';';
- }
- }
-
/**
* boolean, short and char variable are considered as int in the stack or local variable area. Returns {@link Type#INT}
* for {@link Type#BOOLEAN}, {@link Type#SHORT} or {@link Type#CHAR}, otherwise returns the given type.
diff --git a/src/test/java/org/apache/bcel/BCELBenchmark.java b/src/test/java/org/apache/bcel/BCELBenchmark.java
index 9a81493f..2b62a1ea 100644
--- a/src/test/java/org/apache/bcel/BCELBenchmark.java
+++ b/src/test/java/org/apache/bcel/BCELBenchmark.java
@@ -50,20 +50,6 @@ import org.openjdk.jmh.infra.Blackhole;
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public class BCELBenchmark {
- private JarFile getJarFile() throws IOException {
- final String javaHome = System.getProperty("java.home");
- return new JarFile(javaHome + "/lib/rt.jar");
- }
-
- private Iterable<JarEntry> getClasses(JarFile jar) {
- return new IteratorIterable<>(new FilterIterator<>(new EnumerationIterator<>(jar.entries()), new Predicate<JarEntry>() {
- @Override
- public boolean evaluate(JarEntry entry) {
- return entry.getName().endsWith(JavaClass.EXTENSION);
- }
- }));
- }
-
/**
* Baseline benchmark. Read the classes but don't parse them.
*/
@@ -79,20 +65,6 @@ public class BCELBenchmark {
jar.close();
}
- @Benchmark
- public void parser(Blackhole bh) throws IOException {
- JarFile jar = getJarFile();
-
- for (JarEntry entry : getClasses(jar)) {
- byte[] bytes = IOUtils.toByteArray(jar.getInputStream(entry));
-
- JavaClass clazz = new ClassParser(new ByteArrayInputStream(bytes), entry.getName()).parse();
- bh.consume(clazz);
- }
-
- jar.close();
- }
-
@Benchmark
public void generator(Blackhole bh) throws IOException {
JarFile jar = getJarFile();
@@ -121,4 +93,32 @@ public class BCELBenchmark {
jar.close();
}
+
+ private Iterable<JarEntry> getClasses(JarFile jar) {
+ return new IteratorIterable<>(new FilterIterator<>(new EnumerationIterator<>(jar.entries()), new Predicate<JarEntry>() {
+ @Override
+ public boolean evaluate(JarEntry entry) {
+ return entry.getName().endsWith(JavaClass.EXTENSION);
+ }
+ }));
+ }
+
+ private JarFile getJarFile() throws IOException {
+ final String javaHome = System.getProperty("java.home");
+ return new JarFile(javaHome + "/lib/rt.jar");
+ }
+
+ @Benchmark
+ public void parser(Blackhole bh) throws IOException {
+ JarFile jar = getJarFile();
+
+ for (JarEntry entry : getClasses(jar)) {
+ byte[] bytes = IOUtils.toByteArray(jar.getInputStream(entry));
+
+ JavaClass clazz = new ClassParser(new ByteArrayInputStream(bytes), entry.getName()).parse();
+ bh.consume(clazz);
+ }
+
+ jar.close();
+ }
}
diff --git a/src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java b/src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java
index 6b4d2a4f..c62f6d18 100644
--- a/src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/BREAKPOINTTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class BREAKPOINTTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final BREAKPOINT breakpoint = new BREAKPOINT();
breakpoint.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/D2FTestCase.java b/src/test/java/org/apache/bcel/generic/D2FTestCase.java
index eb80b245..78a8c09c 100644
--- a/src/test/java/org/apache/bcel/generic/D2FTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/D2FTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class D2FTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final D2F d2f = new D2F();
d2f.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/D2ITestCase.java b/src/test/java/org/apache/bcel/generic/D2ITestCase.java
index bba89697..a297ecc9 100644
--- a/src/test/java/org/apache/bcel/generic/D2ITestCase.java
+++ b/src/test/java/org/apache/bcel/generic/D2ITestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class D2ITestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final D2I d2i = new D2I();
d2i.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/D2LTestCase.java b/src/test/java/org/apache/bcel/generic/D2LTestCase.java
index e8ba042a..5cecd832 100644
--- a/src/test/java/org/apache/bcel/generic/D2LTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/D2LTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class D2LTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final D2L d2l = new D2L();
d2l.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/DADDTestCase.java b/src/test/java/org/apache/bcel/generic/DADDTestCase.java
index 2f0bdee8..86b95afc 100644
--- a/src/test/java/org/apache/bcel/generic/DADDTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/DADDTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class DADDTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final DADD dadd = new DADD();
dadd.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/DDIVTestCase.java b/src/test/java/org/apache/bcel/generic/DDIVTestCase.java
index 967135ce..9a7631f8 100644
--- a/src/test/java/org/apache/bcel/generic/DDIVTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/DDIVTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class DDIVTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final DDIV ddiv = new DDIV();
ddiv.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/DMULTestCase.java b/src/test/java/org/apache/bcel/generic/DMULTestCase.java
index 4a0e889d..fae37aae 100644
--- a/src/test/java/org/apache/bcel/generic/DMULTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/DMULTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class DMULTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final DMUL dmul = new DMUL();
dmul.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/DNEGTestCase.java b/src/test/java/org/apache/bcel/generic/DNEGTestCase.java
index dfcc2ae7..48d11140 100644
--- a/src/test/java/org/apache/bcel/generic/DNEGTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/DNEGTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class DNEGTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final DNEG dneg = new DNEG();
dneg.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/DREMTestCase.java b/src/test/java/org/apache/bcel/generic/DREMTestCase.java
index 0e8c3bbf..bc29bf41 100644
--- a/src/test/java/org/apache/bcel/generic/DREMTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/DREMTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class DREMTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final DREM drem = new DREM();
drem.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/DSUBTestCase.java b/src/test/java/org/apache/bcel/generic/DSUBTestCase.java
index 9e04ec9b..0b73263f 100644
--- a/src/test/java/org/apache/bcel/generic/DSUBTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/DSUBTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class DSUBTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final DSUB dsub = new DSUB();
dsub.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/F2DTestCase.java b/src/test/java/org/apache/bcel/generic/F2DTestCase.java
index 02933bc5..edb1733f 100644
--- a/src/test/java/org/apache/bcel/generic/F2DTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/F2DTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class F2DTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final F2D f2d = new F2D();
f2d.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/F2ITestCase.java b/src/test/java/org/apache/bcel/generic/F2ITestCase.java
index 183fe09d..dd2c0b7a 100644
--- a/src/test/java/org/apache/bcel/generic/F2ITestCase.java
+++ b/src/test/java/org/apache/bcel/generic/F2ITestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class F2ITestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final F2I f2i = new F2I();
f2i.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/F2LTestCase.java b/src/test/java/org/apache/bcel/generic/F2LTestCase.java
index 665fbf2e..d0dff2af 100644
--- a/src/test/java/org/apache/bcel/generic/F2LTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/F2LTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class F2LTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final F2L f2l = new F2L();
f2l.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/FADDTestCase.java b/src/test/java/org/apache/bcel/generic/FADDTestCase.java
index 4b8584b3..04b9f716 100644
--- a/src/test/java/org/apache/bcel/generic/FADDTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/FADDTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class FADDTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final FADD fadd = new FADD();
fadd.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/FDIVTestCase.java b/src/test/java/org/apache/bcel/generic/FDIVTestCase.java
index bb141d42..106b66f4 100644
--- a/src/test/java/org/apache/bcel/generic/FDIVTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/FDIVTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class FDIVTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final FDIV fdiv = new FDIV();
fdiv.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/FMULTestCase.java b/src/test/java/org/apache/bcel/generic/FMULTestCase.java
index 3334f9d1..e142a783 100644
--- a/src/test/java/org/apache/bcel/generic/FMULTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/FMULTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class FMULTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final FMUL fmul = new FMUL();
fmul.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/FNEGTestCase.java b/src/test/java/org/apache/bcel/generic/FNEGTestCase.java
index ac59cfe2..ae5a9d40 100644
--- a/src/test/java/org/apache/bcel/generic/FNEGTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/FNEGTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class FNEGTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final FNEG fneg = new FNEG();
fneg.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/FREMTestCase.java b/src/test/java/org/apache/bcel/generic/FREMTestCase.java
index dc6ac980..f2adfe90 100644
--- a/src/test/java/org/apache/bcel/generic/FREMTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/FREMTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class FREMTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final FREM frem = new FREM();
frem.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/FSUBTestCase.java b/src/test/java/org/apache/bcel/generic/FSUBTestCase.java
index a0cb2c92..37481092 100644
--- a/src/test/java/org/apache/bcel/generic/FSUBTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/FSUBTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class FSUBTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final FSUB fsub = new FSUB();
fsub.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/GETFIELDTestCase.java b/src/test/java/org/apache/bcel/generic/GETFIELDTestCase.java
index dc65c255..cd51449b 100644
--- a/src/test/java/org/apache/bcel/generic/GETFIELDTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/GETFIELDTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class GETFIELDTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final GETFIELD getfield = new GETFIELD(0);
getfield.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/I2BTestCase.java b/src/test/java/org/apache/bcel/generic/I2BTestCase.java
index f22e2018..26626605 100644
--- a/src/test/java/org/apache/bcel/generic/I2BTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/I2BTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class I2BTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final I2B i2b = new I2B();
i2b.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/I2CTestCase.java b/src/test/java/org/apache/bcel/generic/I2CTestCase.java
index ced06757..7e369507 100644
--- a/src/test/java/org/apache/bcel/generic/I2CTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/I2CTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class I2CTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final I2C i2c = new I2C();
i2c.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/I2DTestCase.java b/src/test/java/org/apache/bcel/generic/I2DTestCase.java
index be926229..fdca82d3 100644
--- a/src/test/java/org/apache/bcel/generic/I2DTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/I2DTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class I2DTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final I2D i2d = new I2D();
i2d.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/I2FTestCase.java b/src/test/java/org/apache/bcel/generic/I2FTestCase.java
index a941f9f8..28976dbf 100644
--- a/src/test/java/org/apache/bcel/generic/I2FTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/I2FTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class I2FTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final I2F i2f = new I2F();
i2f.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/I2LTestCase.java b/src/test/java/org/apache/bcel/generic/I2LTestCase.java
index 45aafac9..6daffa54 100644
--- a/src/test/java/org/apache/bcel/generic/I2LTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/I2LTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class I2LTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final I2L i2l = new I2L();
i2l.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/I2STestCase.java b/src/test/java/org/apache/bcel/generic/I2STestCase.java
index 5e270a6d..aa80fb4e 100644
--- a/src/test/java/org/apache/bcel/generic/I2STestCase.java
+++ b/src/test/java/org/apache/bcel/generic/I2STestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class I2STestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final I2S i2s = new I2S();
i2s.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/IADDTestCase.java b/src/test/java/org/apache/bcel/generic/IADDTestCase.java
index 1bc09a7f..79475a2a 100644
--- a/src/test/java/org/apache/bcel/generic/IADDTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/IADDTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class IADDTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final IADD iadd = new IADD();
iadd.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/IANDTestCase.java b/src/test/java/org/apache/bcel/generic/IANDTestCase.java
index 40354c32..fcef7234 100644
--- a/src/test/java/org/apache/bcel/generic/IANDTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/IANDTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class IANDTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final IAND iand = new IAND();
iand.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/IDIVTestCase.java b/src/test/java/org/apache/bcel/generic/IDIVTestCase.java
index 1bccfc8d..dfd582ca 100644
--- a/src/test/java/org/apache/bcel/generic/IDIVTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/IDIVTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class IDIVTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final IDIV idiv = new IDIV();
idiv.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/IMPDEP1TestCase.java b/src/test/java/org/apache/bcel/generic/IMPDEP1TestCase.java
index 415fa5e3..28cfb373 100644
--- a/src/test/java/org/apache/bcel/generic/IMPDEP1TestCase.java
+++ b/src/test/java/org/apache/bcel/generic/IMPDEP1TestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class IMPDEP1TestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final IMPDEP1 impdep1 = new IMPDEP1();
impdep1.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/IMPDEP2TestCase.java b/src/test/java/org/apache/bcel/generic/IMPDEP2TestCase.java
index 517fa4aa..7aef908e 100644
--- a/src/test/java/org/apache/bcel/generic/IMPDEP2TestCase.java
+++ b/src/test/java/org/apache/bcel/generic/IMPDEP2TestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class IMPDEP2TestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final IMPDEP2 impdep2 = new IMPDEP2();
impdep2.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/IMULTestCase.java b/src/test/java/org/apache/bcel/generic/IMULTestCase.java
index b898b7dd..9f233ed5 100644
--- a/src/test/java/org/apache/bcel/generic/IMULTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/IMULTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class IMULTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final IMUL imul = new IMUL();
imul.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/INEGTestCase.java b/src/test/java/org/apache/bcel/generic/INEGTestCase.java
index 253b0044..c6b70752 100644
--- a/src/test/java/org/apache/bcel/generic/INEGTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/INEGTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class INEGTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final INEG ineg = new INEG();
ineg.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/IORTestCase.java b/src/test/java/org/apache/bcel/generic/IORTestCase.java
index 76aa1dd5..9078c8a8 100644
--- a/src/test/java/org/apache/bcel/generic/IORTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/IORTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class IORTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final IOR ior = new IOR();
ior.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/IREMTestCase.java b/src/test/java/org/apache/bcel/generic/IREMTestCase.java
index a829539c..e00d9636 100644
--- a/src/test/java/org/apache/bcel/generic/IREMTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/IREMTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class IREMTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final IREM irem = new IREM();
irem.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/ISHLTestCase.java b/src/test/java/org/apache/bcel/generic/ISHLTestCase.java
index 3d3596d3..262a1e9a 100644
--- a/src/test/java/org/apache/bcel/generic/ISHLTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/ISHLTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class ISHLTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final ISHL ishl = new ISHL();
ishl.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/ISHRTestCase.java b/src/test/java/org/apache/bcel/generic/ISHRTestCase.java
index 0868e345..85d21765 100644
--- a/src/test/java/org/apache/bcel/generic/ISHRTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/ISHRTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class ISHRTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final ISHR ishr = new ISHR();
ishr.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/ISUBTestCase.java b/src/test/java/org/apache/bcel/generic/ISUBTestCase.java
index ef5012e0..6cc97699 100644
--- a/src/test/java/org/apache/bcel/generic/ISUBTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/ISUBTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class ISUBTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final ISUB isub = new ISUB();
isub.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/IXORTestCase.java b/src/test/java/org/apache/bcel/generic/IXORTestCase.java
index 8d27121f..6c48d971 100644
--- a/src/test/java/org/apache/bcel/generic/IXORTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/IXORTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class IXORTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final IXOR ixor = new IXOR();
ixor.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/L2DTestCase.java b/src/test/java/org/apache/bcel/generic/L2DTestCase.java
index 314f1f80..453b6c4e 100644
--- a/src/test/java/org/apache/bcel/generic/L2DTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/L2DTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class L2DTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final L2D l2d = new L2D();
l2d.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/L2FTestCase.java b/src/test/java/org/apache/bcel/generic/L2FTestCase.java
index 44d4997d..4b9055c2 100644
--- a/src/test/java/org/apache/bcel/generic/L2FTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/L2FTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class L2FTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final L2F l2f = new L2F();
l2f.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/L2ITestCase.java b/src/test/java/org/apache/bcel/generic/L2ITestCase.java
index 3cfbb8c4..8d0cccd5 100644
--- a/src/test/java/org/apache/bcel/generic/L2ITestCase.java
+++ b/src/test/java/org/apache/bcel/generic/L2ITestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class L2ITestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final L2I l2i = new L2I();
l2i.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LADDTestCase.java b/src/test/java/org/apache/bcel/generic/LADDTestCase.java
index f021c8e6..6d1276f7 100644
--- a/src/test/java/org/apache/bcel/generic/LADDTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LADDTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LADDTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LADD ladd = new LADD();
ladd.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LANDTestCase.java b/src/test/java/org/apache/bcel/generic/LANDTestCase.java
index 962543a8..14fdcdd8 100644
--- a/src/test/java/org/apache/bcel/generic/LANDTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LANDTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LANDTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LAND land = new LAND();
land.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LCMPTestCase.java b/src/test/java/org/apache/bcel/generic/LCMPTestCase.java
index 3c75fcb9..d0c1c0d5 100644
--- a/src/test/java/org/apache/bcel/generic/LCMPTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LCMPTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LCMPTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LCMP lcmp = new LCMP();
lcmp.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LDIVTestCase.java b/src/test/java/org/apache/bcel/generic/LDIVTestCase.java
index 59467dd4..e1f4e984 100644
--- a/src/test/java/org/apache/bcel/generic/LDIVTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LDIVTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LDIVTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LDIV ldiv = new LDIV();
ldiv.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LMULTestCase.java b/src/test/java/org/apache/bcel/generic/LMULTestCase.java
index 8422b72a..7d2b1e04 100644
--- a/src/test/java/org/apache/bcel/generic/LMULTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LMULTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LMULTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LMUL lmul = new LMUL();
lmul.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LNEGTestCase.java b/src/test/java/org/apache/bcel/generic/LNEGTestCase.java
index b87ba6a9..df30aca3 100644
--- a/src/test/java/org/apache/bcel/generic/LNEGTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LNEGTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LNEGTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LNEG lneg = new LNEG();
lneg.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LORTestCase.java b/src/test/java/org/apache/bcel/generic/LORTestCase.java
index 5e0b0382..4414104b 100644
--- a/src/test/java/org/apache/bcel/generic/LORTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LORTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LORTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LOR lor = new LOR();
lor.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LREMTestCase.java b/src/test/java/org/apache/bcel/generic/LREMTestCase.java
index ff950d79..14458e4a 100644
--- a/src/test/java/org/apache/bcel/generic/LREMTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LREMTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LREMTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LREM lrem = new LREM();
lrem.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LSHLTestCase.java b/src/test/java/org/apache/bcel/generic/LSHLTestCase.java
index 507b6fc1..6cda61d6 100644
--- a/src/test/java/org/apache/bcel/generic/LSHLTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LSHLTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LSHLTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LSHL lshl = new LSHL();
lshl.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LSHRTestCase.java b/src/test/java/org/apache/bcel/generic/LSHRTestCase.java
index 7a4276cc..ae1fb212 100644
--- a/src/test/java/org/apache/bcel/generic/LSHRTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LSHRTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LSHRTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LSHR lshr = new LSHR();
lshr.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LSUBTestCase.java b/src/test/java/org/apache/bcel/generic/LSUBTestCase.java
index 46a154f5..17b3a342 100644
--- a/src/test/java/org/apache/bcel/generic/LSUBTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LSUBTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LSUBTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LSUB lsub = new LSUB();
lsub.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/LXORTestCase.java b/src/test/java/org/apache/bcel/generic/LXORTestCase.java
index 4d8578a0..3492b2bd 100644
--- a/src/test/java/org/apache/bcel/generic/LXORTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/LXORTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class LXORTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final LXOR lxor = new LXOR();
lxor.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/PUTFIELDTestCase.java b/src/test/java/org/apache/bcel/generic/PUTFIELDTestCase.java
index 37347108..71796bf8 100644
--- a/src/test/java/org/apache/bcel/generic/PUTFIELDTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/PUTFIELDTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class PUTFIELDTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final PUTFIELD putfield = new PUTFIELD(0);
putfield.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/PUTSTATICTestCase.java b/src/test/java/org/apache/bcel/generic/PUTSTATICTestCase.java
index e8bf4424..e4cbb839 100644
--- a/src/test/java/org/apache/bcel/generic/PUTSTATICTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/PUTSTATICTestCase.java
@@ -22,7 +22,7 @@ import org.junit.jupiter.api.Test;
public class PUTSTATICTestCase {
@Test
- public void accept() {
+ public void testAccept() {
final CountingVisitor countVisitor = new CountingVisitor();
final PUTSTATIC putstatic = new PUTSTATIC(0);
putstatic.accept(countVisitor);
diff --git a/src/test/java/org/apache/bcel/generic/TypeTestCase.java b/src/test/java/org/apache/bcel/generic/TypeTestCase.java
index 8d441b88..4fd5c116 100644
--- a/src/test/java/org/apache/bcel/generic/TypeTestCase.java
+++ b/src/test/java/org/apache/bcel/generic/TypeTestCase.java
@@ -39,6 +39,18 @@ public class TypeTestCase {
assertEquals(expectedValue, actualValue, "Type.getType");
}
+ @Test
+ public void testInternalTypeNametoSignature() {
+ assertEquals(null, Type.internalTypeNameToSignature(null));
+ assertEquals("", Type.internalTypeNameToSignature(""));
+ assertEquals("TT;", Type.internalTypeNameToSignature("TT;"));
+ assertEquals("Ljava/lang/String;", Type.internalTypeNameToSignature("Ljava/lang/String;"));
+ assertEquals("[Ljava/lang/String;", Type.internalTypeNameToSignature("[Ljava/lang/String;"));
+ assertEquals("Ljava/lang/String;", Type.internalTypeNameToSignature("java/lang/String"));
+ assertEquals("I", Type.internalTypeNameToSignature("I"));
+ assertEquals("LT;", Type.internalTypeNameToSignature("T"));
+ }
+
@ParameterizedTest
@ValueSource(strings = {
// @formatter:off
@@ -86,16 +98,4 @@ public class TypeTestCase {
}
}
}
-
- @Test
- public void testInternalTypeNametoSignature() {
- assertEquals(null, Type.internalTypeNameToSignature(null));
- assertEquals("", Type.internalTypeNameToSignature(""));
- assertEquals("TT;", Type.internalTypeNameToSignature("TT;"));
- assertEquals("Ljava/lang/String;", Type.internalTypeNameToSignature("Ljava/lang/String;"));
- assertEquals("[Ljava/lang/String;", Type.internalTypeNameToSignature("[Ljava/lang/String;"));
- assertEquals("Ljava/lang/String;", Type.internalTypeNameToSignature("java/lang/String"));
- assertEquals("I", Type.internalTypeNameToSignature("I"));
- assertEquals("LT;", Type.internalTypeNameToSignature("T"));
- }
}