You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/12 00:21:52 UTC
[GitHub] [spark] rdblue commented on issue #26817: [SPARK-30192][SQL]
support column position in DS v2
rdblue commented on issue #26817: [SPARK-30192][SQL] support column position in DS v2
URL: https://github.com/apache/spark/pull/26817#issuecomment-564793076
@cloud-fan, thanks for fixing this! Mostly looks good to me, but I found a few minor things to fix.
Also, I think this should update the in-memory tables to implement reorder and test the behavior. It seems strange to have tests for all the other ALTER TABLE features, but not ordering.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org