[GitHub] [hadoop] goiri commented on a diff in pull request #5066: HADOOP-18506. Update build instructions for Windows using VS2019

[GitBox <gi...@apache.org>]

goiri commented on code in PR #5066:
URL: https://github.com/apache/hadoop/pull/5066#discussion_r1002544982


##########
BUILDING.txt:
##########
@@ -540,6 +564,11 @@ configure the bit-ness of the build, and set several optional components.
 Several tests require that the user must have the Create Symbolic Links
 privilege.
 
+To simplify the installation of Boost, Protocol buffers, OpenSSL and Zlib dependencies we can use
+vcpkg (https://github.com/Microsoft/vcpkg.git). Upon cloning the vcpkg repo, checkout the commit
+7ffa425e1db8b0c3edf9c50f2f3a0f25a324541d to get the required versions of the dependencies

Review Comment:
   Why not a specific branch or latest?
   It would also be good to add the command.



##########
BUILDING.txt:
##########
@@ -492,39 +492,63 @@ Building on CentOS 8
 
 ----------------------------------------------------------------------------------
 
-Building on Windows
+Building on Windows 10
 
 ----------------------------------------------------------------------------------
 Requirements:
 
-* Windows System
+* Windows 10
 * JDK 1.8
 * Maven 3.0 or later
 * Boost 1.72
 * Protocol Buffers 3.7.1
 * CMake 3.19 or newer
-* Visual Studio 2010 Professional or Higher
-* Windows SDK 8.1 (if building CPU rate control for the container executor)
-* zlib headers (if building native code bindings for zlib)
+* Visual Studio 2019
+* Windows SDK 8.1 (optional, if building CPU rate control for the container executor)
+* Zlib (if building native code bindings for zlib)

Review Comment:
   Can we add links to these components?



##########
BUILDING.txt:
##########
@@ -557,6 +586,22 @@ the zlib 1.2.7 source tree.
 
 http://www.zlib.net/
 
+
+Build command:
+The following command builds all the modules in the Hadoop project and generates the tar.gz file in
+hadoop-dist/target upon successful build. Run these commands from an
+"x64 Native Tools Command Prompt for VS 2019" which can be found under "Visual Studio 2019" in the
+Windows start menu.
+
+> set classpath=

Review Comment:
   In markdown I think you can use the triple quote to make it look like a command.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org