You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "StevenLuMT (via GitHub)" <gi...@apache.org> on 2025/05/07 06:27:45 UTC
[PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
StevenLuMT opened a new pull request, #24263:
URL: https://github.com/apache/pulsar/pull/24263
### Motivation
[zstd-jni](https://github.com/luben/zstd-jni ) would be useful to have zstd upgraded to latest version.
- [zstd v1.5.7 release notes](https://github.com/facebook/zstd/releases/tag/v1.5.7)
- [zstd-jni v1.5.7-3 release notes](https://github.com/luben/zstd-jni/releases/tag/v1.5.7-3)
### Modifications
Upgrade zstd version from 1.5.2-3 to 1.5.7-3
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
Check the box below or label this PR directly.
Need to update docs?
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: https://github.com/StevenLuMT/pulsar/pull/12
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2857910396
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2859365924
I think it's probably not used anymore, since we switched to java implementation of ZStd few years ago
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2861178757
> I think it's probably not used anymore, since we switched to java implementation of ZStd few years ago
@merlimat Good suggestion. I think zstd-jni can be explained and upgraded. But to solve the fundamental problem, I will submit a PR to https://github.com/apache/commons-compress and upgrade from commons-compress.
<img width="889" alt="image" src="https://github.com/user-attachments/assets/cea52803-1180-4505-9d0e-f74405f8d145" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2861880331
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2861098365
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2858101567
> > /pulsarbot run-failure-checks
>
> @StevenLuMT Pulsar CI is currently broken. SchemaTest.testPendingQueueSizeIfIncompatible fails consistently. I'm disabling that in #24261
Got it,Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "liangyepianzhou (via GitHub)" <gi...@apache.org>.
liangyepianzhou merged PR #24263:
URL: https://github.com/apache/pulsar/pull/24263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2861118016
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2861481514
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/24263?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 74.26%. Comparing base [(`bbc6224`)](https://app.codecov.io/gh/apache/pulsar/commit/bbc62245c5ddba1de4b1e7cee4ab49334bc36277?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`cc73410`)](https://app.codecov.io/gh/apache/pulsar/commit/cc73410d501a29ddb2e2a710da3c254f4b0e40b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 1080 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/pulsar/pull/24263?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #24263 +/- ##
============================================
+ Coverage 73.57% 74.26% +0.69%
+ Complexity 32624 32611 -13
============================================
Files 1877 1866 -11
Lines 139502 145048 +5546
Branches 15299 16579 +1280
============================================
+ Hits 102638 107727 +5089
+ Misses 28908 28798 -110
- Partials 7956 8523 +567
```
| [Flag](https://app.codecov.io/gh/apache/pulsar/pull/24263/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [inttests](https://app.codecov.io/gh/apache/pulsar/pull/24263/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `26.82% <ø> (+2.24%)` | :arrow_up: |
| [systests](https://app.codecov.io/gh/apache/pulsar/pull/24263/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `23.29% <ø> (-1.04%)` | :arrow_down: |
| [unittests](https://app.codecov.io/gh/apache/pulsar/pull/24263/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `73.75% <ø> (+0.91%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 1082 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/24263/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2857700650
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2857948041
> /pulsarbot run-failure-checks
@StevenLuMT Pulsar CI is currently broken. SchemaTest.testPendingQueueSizeIfIncompatible fails consistently. I'm disabling that in #24261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2857456916
Pulsar doesn't seem to package zstd-jni in the Pulsar distribution directly since the LICENSE files didn't require an update. I guess this library is used by some Pulsar IO connector?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][build] Upgrade zstd version from 1.5.2-3 to 1.5.7-3 [pulsar]
Posted by "StevenLuMT (via GitHub)" <gi...@apache.org>.
StevenLuMT commented on PR #24263:
URL: https://github.com/apache/pulsar/pull/24263#issuecomment-2861106794
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org