[GitHub] [iceberg] ConeyLiu commented on a diff in pull request #5049: Spark: Fixes NPE when convert NOT IN filter

[GitBox <gi...@apache.org>]

ConeyLiu commented on code in PR #5049:
URL: https://github.com/apache/iceberg/pull/5049#discussion_r897893379


##########
spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/SparkFilters.java:
##########
@@ -178,6 +178,7 @@ public static Expression convert(Filter filter) {
             In childInFilter = (In) childFilter;
             Expression notIn = notIn(unquote(childInFilter.attribute()),
                 Stream.of(childInFilter.values())
+                    .filter(Objects::nonNull)

Review Comment:
   This refers to the process in L166. I think this is because we don't support NULL literal in Iceberg. However,  I think here have changed the original filter meanings. @rdblue, should we support NULL literal in Iceberg?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org