You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shiro.apache.org by GitBox <gi...@apache.org> on 2020/03/29 01:18:35 UTC
[GitHub] [shiro] drzhonghao opened a new pull request #208: modifying the
thrown exceptions of SimplePrincipalCollection
drzhonghao opened a new pull request #208: modifying the thrown exceptions of SimplePrincipalCollection
URL: https://github.com/apache/shiro/pull/208
The bug report is https://issues.apache.org/jira/browse/SHIRO-751?page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel&focusedCommentId=17069374#comment-17069374
As suggested by Benjamin Marwell, I change the thrown exceptions of SimplePrincipalCollection#add and SimplePrincipalCollection#allAll
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shiro] fpapon merged pull request #208: [SHIRO-751]
SimplePrincipalMap and SimplePrincipalCollection throw different exceptions
for the same problem
Posted by GitBox <gi...@apache.org>.
fpapon merged pull request #208: [SHIRO-751] SimplePrincipalMap and SimplePrincipalCollection throw different exceptions for the same problem
URL: https://github.com/apache/shiro/pull/208
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shiro] fpapon commented on issue #208: [SHIRO-751]
SimplePrincipalMap and SimplePrincipalCollection throw different exceptions
for the same problem
Posted by GitBox <gi...@apache.org>.
fpapon commented on issue #208: [SHIRO-751] SimplePrincipalMap and SimplePrincipalCollection throw different exceptions for the same problem
URL: https://github.com/apache/shiro/pull/208#issuecomment-605622631
If PR are related to a Jira, the tempalte of the title should be:
`[issue-number] Title-of-the-issue`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shiro] bmhm commented on issue #208: modifying the thrown
exceptions of SimplePrincipalCollection
Posted by GitBox <gi...@apache.org>.
bmhm commented on issue #208: modifying the thrown exceptions of SimplePrincipalCollection
URL: https://github.com/apache/shiro/pull/208#issuecomment-605589856
Two additional comments
1. Please update the title of this PR, the issue in square brackets.
2. I know this is an API change. But for NPE, I feel this is very justified and no one should have cought this exception in the first place.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services