You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "geido (via GitHub)" <gi...@apache.org> on 2024/11/18 14:31:41 UTC
[PR] fix(Card): Use correct class names for Ant Design 5 Card component [superset]
geido opened a new pull request, #30964:
URL: https://github.com/apache/superset/pull/30964
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
This PR #29389 upgraded the Card component to Ant Design 5 but some class names did not make it to the upgrade causing some effects on the layout. This PR fixes that.
### BEFORE
### AFTER
<img width="1493" alt="Screenshot 2024-11-18 at 16 30 44" src="https://github.com/user-attachments/assets/bc545bc1-93a3-4a07-b206-a015e08a1fc6">
### TESTING INSTRUCTIONS
1. Open the welcome page
2. Select "All" under the Charts collapsible
3. Cards should show correctly
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(Card): Use correct class names for Ant Design 5 Card component [superset]
Posted by "geido (via GitHub)" <gi...@apache.org>.
geido merged PR #30964:
URL: https://github.com/apache/superset/pull/30964
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org