You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/10/14 09:50:16 UTC
[GitHub] [apisix-helm-chart] hadican opened a new pull request, #372: fix: use https scheme when etcd.auth.tls.enabled
hadican opened a new pull request, #372:
URL: https://github.com/apache/apisix-helm-chart/pull/372
Eventhough the `etcd.auth.tls.enabled`, `apisix` tries to connect with `http`.
This PR will solve it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers merged pull request #372: fix: use https scheme when etcd.auth.tls.enabled
Posted by GitBox <gi...@apache.org>.
tokers merged PR #372:
URL: https://github.com/apache/apisix-helm-chart/pull/372
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a diff in pull request #372: fix: use https scheme when etcd.auth.tls.enabled
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on code in PR #372:
URL: https://github.com/apache/apisix-helm-chart/pull/372#discussion_r996430549
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -276,12 +276,21 @@ data:
role: viewer
etcd:
{{- if .Values.etcd.enabled }}
+ {{- if .Values.etcd.auth.tls.enabled }}
+ host: # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+ {{- if .Values.etcd.fullnameOverride }}
+ - "https://{{ .Values.etcd.fullnameOverride }}:{{ .Values.etcd.service.port }}"
Review Comment:
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #372: fix: use https scheme when etcd.auth.tls.enabled
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #372:
URL: https://github.com/apache/apisix-helm-chart/pull/372#discussion_r996423441
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -276,12 +276,21 @@ data:
role: viewer
etcd:
{{- if .Values.etcd.enabled }}
+ {{- if .Values.etcd.auth.tls.enabled }}
+ host: # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+ {{- if .Values.etcd.fullnameOverride }}
+ - "https://{{ .Values.etcd.fullnameOverride }}:{{ .Values.etcd.service.port }}"
Review Comment:
Is it possible to define a `scheme` variable here (see https://helm.sh/docs/chart_template_guide/variables/), so that we can reduce the template complexity?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] hadican commented on a diff in pull request #372: fix: use https scheme when etcd.auth.tls.enabled
Posted by GitBox <gi...@apache.org>.
hadican commented on code in PR #372:
URL: https://github.com/apache/apisix-helm-chart/pull/372#discussion_r996806146
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -276,12 +276,21 @@ data:
role: viewer
etcd:
{{- if .Values.etcd.enabled }}
+ {{- if .Values.etcd.auth.tls.enabled }}
+ host: # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+ {{- if .Values.etcd.fullnameOverride }}
+ - "https://{{ .Values.etcd.fullnameOverride }}:{{ .Values.etcd.service.port }}"
Review Comment:
How about a helper like:
```
{{/*
Scheme to use while connecting etcd
*/}}
{{- define "apisix.etcd.auth.scheme" -}}
{{- if .Values.etcd.auth.tls.enabled }}
{{- "https" }}
{{- else }}
{{- "http" }}
{{- end }}
{{- end }}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a diff in pull request #372: fix: use https scheme when etcd.auth.tls.enabled
Posted by GitBox <gi...@apache.org>.
tokers commented on code in PR #372:
URL: https://github.com/apache/apisix-helm-chart/pull/372#discussion_r996880314
##########
charts/apisix/templates/configmap.yaml:
##########
@@ -276,12 +276,21 @@ data:
role: viewer
etcd:
{{- if .Values.etcd.enabled }}
+ {{- if .Values.etcd.auth.tls.enabled }}
+ host: # it's possible to define multiple etcd hosts addresses of the same etcd cluster.
+ {{- if .Values.etcd.fullnameOverride }}
+ - "https://{{ .Values.etcd.fullnameOverride }}:{{ .Values.etcd.service.port }}"
Review Comment:
Cool.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org