[GitHub] [hudi] xushiyan commented on a diff in pull request #6227: [HUDI-4496] Fixing Orc support broken for Spark 3.x and more

[GitBox <gi...@apache.org>]

xushiyan commented on code in PR #6227:
URL: https://github.com/apache/hudi/pull/6227#discussion_r1005945009


##########
pom.xml:
##########
@@ -1728,6 +1736,9 @@
         <hudi.spark.common.module>hudi-spark3-common</hudi.spark.common.module>
         <scalatest.version>${scalatest.spark3.version}</scalatest.version>
         <kafka.version>${kafka.spark3.version}</kafka.version>
+        <parquet.version>1.10.1</parquet.version>

Review Comment:
   this is the default version. but it's good to explicitly state it to keep in sync with spark



##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -639,7 +639,6 @@
       <groupId>org.apache.orc</groupId>
       <artifactId>orc-core</artifactId>
       <version>${orc.version}</version>
-      <classifier>nohive</classifier>

Review Comment:
   looks like flink bundle does not shade orc. this change may impact on flink usage. let's have this change and shading in a separate PR? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org