[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #4062: [VMware] Cannot migrate VM on PVLAN shared network

[GitBox <gi...@apache.org>]

sureshanaparti commented on a change in pull request #4062:
URL: https://github.com/apache/cloudstack/pull/4062#discussion_r425173131



##########
File path: server/src/main/java/com/cloud/network/element/VirtualRouterElement.java
##########
@@ -1223,8 +1223,7 @@ public boolean prepareMigration(final NicProfile nic, final Network network, fin
             }
         } else if (vm.getType() == VirtualMachine.Type.User) {
             assert vm instanceof UserVmVO;
-            final UserVmVO userVm = (UserVmVO) vm.getVirtualMachine();

Review comment:
       @nvazquez Have you observed similar issues with router VM using similar type casting in the if stmt above. eg: `DomainRouterVO router = (DomainRouterVO) vm.getVirtualMachine();`. Same casting is being used for router VM in other methods below.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org