[jira] [Commented] (AIRFLOW-7008) Add perf kit with common used decorators/contexts

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-7008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17098616#comment-17098616 ] 

ASF GitHub Bot commented on AIRFLOW-7008:
-----------------------------------------

mik-laj commented on a change in pull request #7650:
URL: https://github.com/apache/airflow/pull/7650#discussion_r419183415



##########
File path: scripts/perf/perf_kit/python.py
##########
@@ -0,0 +1,108 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+import contextlib
+import cProfile
+import datetime
+import io
+import os
+import pstats
+import signal
+
+PYSPY_OUTPUT = os.environ.get("PYSPY_OUTPUT", "/files/pyspy/")
+
+
+@contextlib.contextmanager
+def pyspy():
+    """
+    This decorator provide deterministic profiling. It generate and save flame graph to file. It uses``pyspy``
+    internally.
+
+    Running py-spy inside of a docker container will also usually bring up a permissions denied error
+    even when running as root.
+
+    This error is caused by docker restricting the process_vm_readv system call we are using. This can be

Review comment:
       It will be difficult because this error happens in the subprocess. It would be necessary to check whether this process started correctly, which will affect the result. When we run the process, we immediately need to start executing the observed code. Otherwise, we will have junk data in the diagram.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add perf kit with common used decorators/contexts
> -------------------------------------------------
>
>                 Key: AIRFLOW-7008
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-7008
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 1.10.9
>            Reporter: Kamil Bregula
>            Priority: Minor
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)