You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2022/04/28 00:28:14 UTC
[GitHub] [gobblin] ZihanLi58 opened a new pull request, #3497: [GOBBLIN-1636] Close DatasetCleaner after clean task
ZihanLi58 opened a new pull request, #3497:
URL: https://github.com/apache/gobblin/pull/3497
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-1636
### Description
- [ ] Here are some details about my PR, including screenshots (if applicable):
DatasetCleaner internally launches the clean tasks for each version of the dataset in an ExecutorService and then waits for the tasks to get completed in the close() method but since DatasetCleanerTask never invokes close() soWe observed that the Gobblin tasks and Job finish early and don’t wait for all the dataset versions to get deleted successfully.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 merged pull request #3497: [GOBBLIN-1636] Close DatasetCleaner after clean task
Posted by GitBox <gi...@apache.org>.
ZihanLi58 merged PR #3497:
URL: https://github.com/apache/gobblin/pull/3497
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] ZihanLi58 commented on pull request #3497: [GOBBLIN-1636] Close DatasetCleaner after clean task
Posted by GitBox <gi...@apache.org>.
ZihanLi58 commented on PR #3497:
URL: https://github.com/apache/gobblin/pull/3497#issuecomment-1111607300
@vikrambohra can you help take a look when you have chance?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [gobblin] codecov-commenter commented on pull request #3497: [GOBBLIN-1636] Close DatasetCleaner after clean task
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3497:
URL: https://github.com/apache/gobblin/pull/3497#issuecomment-1111614469
# [Codecov](https://codecov.io/gh/apache/gobblin/pull/3497?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3497](https://codecov.io/gh/apache/gobblin/pull/3497?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ac42856) into [master](https://codecov.io/gh/apache/gobblin/commit/065027891e137dc18af8d1ac8b6a9680682774ea?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0650278) will **decrease** coverage by `3.22%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3497 +/- ##
============================================
- Coverage 46.70% 43.47% -3.23%
+ Complexity 10400 2038 -8362
============================================
Files 2077 405 -1672
Lines 81158 17435 -63723
Branches 9060 2129 -6931
============================================
- Hits 37904 7580 -30324
+ Misses 39763 9014 -30749
+ Partials 3491 841 -2650
```
| [Impacted Files](https://codecov.io/gh/apache/gobblin/pull/3497?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...a/org/apache/gobblin/cluster/GobblinHelixTask.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jbHVzdGVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NsdXN0ZXIvR29iYmxpbkhlbGl4VGFzay5qYXZh) | `60.21% <0.00%> (-2.16%)` | :arrow_down: |
| [...e/gobblin/runtime/retention/DatasetCleanerCli.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9yZXRlbnRpb24vRGF0YXNldENsZWFuZXJDbGkuamF2YQ==) | | |
| [.../gobblin/runtime/retention/DatasetCleanerTask.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vcnVudGltZS9yZXRlbnRpb24vRGF0YXNldENsZWFuZXJUYXNrLmphdmE=) | | |
| [...n/data/management/retention/DatasetCleanerJob.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tYXprYWJhbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9kYXRhL21hbmFnZW1lbnQvcmV0ZW50aW9uL0RhdGFzZXRDbGVhbmVySm9iLmphdmE=) | | |
| [.../apache/gobblin/source/jdbc/TeradataExtractor.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1tb2R1bGVzL2dvYmJsaW4tc3FsL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3NvdXJjZS9qZGJjL1RlcmFkYXRhRXh0cmFjdG9yLmphdmE=) | | |
| [...ta/management/trash/NoopSnapshotCleanupPolicy.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1kYXRhLW1hbmFnZW1lbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vZGF0YS9tYW5hZ2VtZW50L3RyYXNoL05vb3BTbmFwc2hvdENsZWFudXBQb2xpY3kuamF2YQ==) | | |
| [...obblin/runtime/template/InheritingJobTemplate.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1ydW50aW1lL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL3J1bnRpbWUvdGVtcGxhdGUvSW5oZXJpdGluZ0pvYlRlbXBsYXRlLmphdmE=) | | |
| [...java/org/apache/gobblin/hive/HiveSerDeManager.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1oaXZlLXJlZ2lzdHJhdGlvbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi9oaXZlL0hpdmVTZXJEZU1hbmFnZXIuamF2YQ==) | | |
| [...bblin/broker/gobblin\_scopes/GobblinScopeTypes.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2dvYmJsaW4vYnJva2VyL2dvYmJsaW5fc2NvcGVzL0dvYmJsaW5TY29wZVR5cGVzLmphdmE=) | | |
| [...compaction/verify/CompactionTimeRangeVerifier.java](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Z29iYmxpbi1jb21wYWN0aW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9nb2JibGluL2NvbXBhY3Rpb24vdmVyaWZ5L0NvbXBhY3Rpb25UaW1lUmFuZ2VWZXJpZmllci5qYXZh) | | |
| ... and [1666 more](https://codecov.io/gh/apache/gobblin/pull/3497/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/gobblin/pull/3497?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/gobblin/pull/3497?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0650278...ac42856](https://codecov.io/gh/apache/gobblin/pull/3497?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org