You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/06/01 10:02:51 UTC

[GitHub] [arrow-datafusion] Ted-Jiang opened a new pull request, #2608: chore: try fix CI coverage

Ted-Jiang opened a new pull request, #2608:
URL: https://github.com/apache/arrow-datafusion/pull/2608

   # Which issue does this PR close?
   
   test for fix ci.
   
   Closes #.
   
    # Rationale for this change
   <!--
    Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
    Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.  
   -->
   
   # What changes are included in this PR?
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!--
   If there are any breaking changes to public APIs, please add the `api change` label.
   -->
   
   # Does this PR break compatibility with Ballista?
   
   <!--
   The CI checks will attempt to build [arrow-ballista](https://github.com/apache/arrow-ballista) against this PR. If 
   this check fails then it indicates that this PR makes a breaking change to the DataFusion API.
   
   If possible, try to make the change in a way that is not a breaking API change. For example, if code has moved 
    around, try adding `pub use` from the original location to preserve the current API.
   
   If it is not possible to avoid a breaking change (such as when adding enum variants) then follow this process:
   
   - Make a corresponding PR against `arrow-ballista` with the changes required there
   - Update `dev/build-arrow-ballista.sh` to clone the appropriate `arrow-ballista` repo & branch
   - Merge this PR when CI passes
   - Merge the Ballista PR
   - Create a new PR here to reset `dev/build-arrow-ballista.sh` to point to `arrow-ballista` master again
   
   _If you would like to help improve this process, please see https://github.com/apache/arrow-datafusion/issues/2583_
   -->


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb merged pull request #2608: chore: try fix CI coverage

Posted by GitBox <gi...@apache.org>.
alamb merged PR #2608:
URL: https://github.com/apache/arrow-datafusion/pull/2608


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Ted-Jiang commented on pull request #2608: chore: try fix CI coverage

Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on PR #2608:
URL: https://github.com/apache/arrow-datafusion/pull/2608#issuecomment-1143303726

   @alamb  seems ci coverage recover now.😊


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #2608: chore: try fix CI coverage

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #2608:
URL: https://github.com/apache/arrow-datafusion/pull/2608#issuecomment-1143103775

   # [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2608?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2608](https://codecov.io/gh/apache/arrow-datafusion/pull/2608?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5d19de4) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/4a55364448c81182731f4fa4c3e65aef5b31fa0f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4a55364) will **increase** coverage by `8.54%`.
   > The diff coverage is `37.50%`.
   
   > :exclamation: Current head 5d19de4 differs from pull request most recent head 1d4c840. Consider uploading reports for the commit 1d4c840 to get more accurate results
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #2608      +/-   ##
   ==========================================
   + Coverage   76.06%   84.60%   +8.54%     
   ==========================================
     Files         156      268     +112     
     Lines       27124    46798   +19674     
   ==========================================
   + Hits        20631    39594   +18963     
   - Misses       6493     7204     +711     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/2608?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [benchmarks/src/bin/nyctaxi.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVuY2htYXJrcy9zcmMvYmluL255Y3RheGkucnM=) | `0.00% <0.00%> (ø)` | |
   | [datafusion/common/src/column.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL2NvbHVtbi5ycw==) | `95.12% <ø> (ø)` | |
   | [datafusion/common/src/dfschema.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL2Rmc2NoZW1hLnJz) | `97.77% <ø> (ø)` | |
   | [datafusion/common/src/error.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL2Vycm9yLnJz) | `82.27% <ø> (ø)` | |
   | [datafusion/common/src/pyarrow.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL3B5YXJyb3cucnM=) | `0.00% <ø> (ø)` | |
   | [datafusion/common/src/scalar.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb21tb24vc3JjL3NjYWxhci5ycw==) | `75.17% <ø> (ø)` | |
   | [datafusion/core/benches/parquet\_query\_sql.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL2JlbmNoZXMvcGFycXVldF9xdWVyeV9zcWwucnM=) | `0.00% <ø> (ø)` | |
   | [datafusion/core/fuzz-utils/src/lib.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL2Z1enotdXRpbHMvc3JjL2xpYi5ycw==) | `100.00% <ø> (ø)` | |
   | [...usion/core/src/avro\_to\_arrow/arrow\_array\_reader.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9hdnJvX3RvX2Fycm93L2Fycm93X2FycmF5X3JlYWRlci5ycw==) | `0.00% <ø> (ø)` | |
   | [datafusion/core/src/avro\_to\_arrow/mod.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGF0YWZ1c2lvbi9jb3JlL3NyYy9hdnJvX3RvX2Fycm93L21vZC5ycw==) | `42.85% <ø> (ø)` | |
   | ... and [379 more](https://codecov.io/gh/apache/arrow-datafusion/pull/2608/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2608?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/2608?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [33dcd02...1d4c840](https://codecov.io/gh/apache/arrow-datafusion/pull/2608?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Ted-Jiang commented on a diff in pull request #2608: chore: try fix CI coverage

Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2608:
URL: https://github.com/apache/arrow-datafusion/pull/2608#discussion_r886674252


##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -737,6 +737,7 @@ async fn test_physical_plan_display_indent_multi_children() {
 }
 
 #[tokio::test]
+#[cfg_attr(tarpaulin, ignore)]

Review Comment:
   Plan not equal but i run in my local, these test work well...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #2608: chore: try fix CI coverage

Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2608:
URL: https://github.com/apache/arrow-datafusion/pull/2608#issuecomment-1144064733

   Thanks @Ted-Jiang 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Ted-Jiang commented on a diff in pull request #2608: chore: try fix CI coverage

Posted by GitBox <gi...@apache.org>.
Ted-Jiang commented on code in PR #2608:
URL: https://github.com/apache/arrow-datafusion/pull/2608#discussion_r886547226


##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -737,6 +737,7 @@ async fn test_physical_plan_display_indent_multi_children() {
 }
 
 #[tokio::test]
+#[cfg_attr(tarpaulin, ignore)]

Review Comment:
   These 4 tests run fail in `coverage`(don't know why 🤕 ), so i try to ignore them in coverage, but they still check in `cargo test`.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] Ted-Jiang closed pull request #2608: chore: try fix CI coverage

Posted by GitBox <gi...@apache.org>.
Ted-Jiang closed pull request #2608: chore: try fix CI coverage
URL: https://github.com/apache/arrow-datafusion/pull/2608


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2608: chore: try fix CI coverage

Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2608:
URL: https://github.com/apache/arrow-datafusion/pull/2608#discussion_r886668842


##########
datafusion/core/tests/sql/explain_analyze.rs:
##########
@@ -737,6 +737,7 @@ async fn test_physical_plan_display_indent_multi_children() {
 }
 
 #[tokio::test]
+#[cfg_attr(tarpaulin, ignore)]

Review Comment:
   How did they fail? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org