You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ah...@apache.org on 2020/02/18 00:16:14 UTC

[commons-geometry] 01/08: Update checkstyle

This is an automated email from the ASF dual-hosted git repository.

aherbert pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git

commit 749448646aadae76b85a41147fb69e1811a144b1
Author: Alex Herbert <a....@sussex.ac.uk>
AuthorDate: Mon Feb 17 23:15:31 2020 +0000

    Update checkstyle
    
    maven plugin 3.0.0 -> 3.1.0
    Dependency 8.20 -> 8.29
---
 pom.xml                                      |  4 ++--
 src/main/resources/checkstyle/checkstyle.xml | 19 ++++++++-----------
 2 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/pom.xml b/pom.xml
index 6823431..a7417da 100644
--- a/pom.xml
+++ b/pom.xml
@@ -55,8 +55,8 @@
     <maven.compiler.target>1.8</maven.compiler.target>
     <geometry.pmd.version>3.9.0</geometry.pmd.version>
     <geometry.pmd.dep.version>6.14.0</geometry.pmd.dep.version>
-    <geometry.checkstyle.version>3.0.0</geometry.checkstyle.version>
-    <geometry.checkstyle.dep.version>8.20</geometry.checkstyle.dep.version>
+    <geometry.checkstyle.version>3.1.0</geometry.checkstyle.version>
+    <geometry.checkstyle.dep.version>8.29</geometry.checkstyle.dep.version>
     <geometry.mathjax.version>2.7.2</geometry.mathjax.version>
     <!-- Workaround to avoid duplicating config files. -->
     <geometry.parent.dir>${basedir}</geometry.parent.dir>
diff --git a/src/main/resources/checkstyle/checkstyle.xml b/src/main/resources/checkstyle/checkstyle.xml
index d834902..df2fde3 100644
--- a/src/main/resources/checkstyle/checkstyle.xml
+++ b/src/main/resources/checkstyle/checkstyle.xml
@@ -57,6 +57,12 @@
   <!-- Checks for Size Violations. -->
   <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
   <module name="FileLength" />
+  <module name="LineLength">
+    <property name="fileExtensions" value="java"/>
+    <!-- Ignore lines that begin with " * ", such as within a Javadoc comment. -->
+    <property name="ignorePattern" value="^ *\* *[^ ]"/>
+    <property name="max" value="120"/>
+  </module>
 
   <!-- Checks for whitespace -->
   <!-- See http://checkstyle.sourceforge.net/config_whitespace.html -->
@@ -81,12 +87,8 @@
 
     <!-- Checks for Javadoc comments. -->
     <!-- See http://checkstyle.sourceforge.net/config_javadoc.html -->
-    <!-- Require method javadocs, allow undeclared RTE -->
-    <module name="JavadocMethod">
-      <property name="allowUndeclaredRTE" value="true"/>
-      <property name="allowThrowsTagsForSubclasses" value="true"/>
-      <property name="validateThrows" value="false"/>
-    </module>
+    <module name="InvalidJavadocPosition"/>
+    <module name="JavadocMethod" />
     <module name="JavadocType" />
     <module name="JavadocVariable" />
     <module name="JavadocStyle" />
@@ -115,11 +117,6 @@
 
     <!-- Checks for Size Violations. -->
     <!-- See http://checkstyle.sourceforge.net/config_sizes.html -->
-    <module name="LineLength">
-      <!-- Ignore lines that begin with " * ", such as within a Javadoc comment. -->
-      <property name="ignorePattern" value="^ *\* *[^ ]"/>
-      <property name="max" value="120"/>
-    </module>
     <module name="MethodLength" />
     <module name="ParameterNumber" />