You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/05/22 05:49:37 UTC

[GitHub] [incubator-kvrocks] xiaobiaozhao opened a new issue, #601: [NEW] add lz4 lib

xiaobiaozhao opened a new issue, #601:
URL: https://github.com/apache/incubator-kvrocks/issues/601

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   KVrocks not included lz4 lib for lz4 compresssion. Only snappy is not enough,lz4 is a  efficient algorithm.
   
   https://user-images.githubusercontent.com/52393536/168716155-82a51edf-74df-48e5-b047-f4e05a192719.png
   
   ### Solution
   
   1. Add lz4 lib into build file.
   2. Add conf for rocksdb.compression "lz4"
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk commented on issue #601: [NEW] add lz4 lib

Posted by GitBox <gi...@apache.org>.
git-hulk commented on issue #601:
URL: https://github.com/apache/incubator-kvrocks/issues/601#issuecomment-1133877035

   Cool, agreed.
   
   the compression ration and performance are better than `snappy`
   in many scenarios. Someone also requests this feature if my memory serves.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-kvrocks] git-hulk closed issue #601: [NEW] add lz4 lib

Posted by GitBox <gi...@apache.org>.
git-hulk closed issue #601: [NEW] add lz4 lib
URL: https://github.com/apache/incubator-kvrocks/issues/601


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org