You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "rusackas (via GitHub)" <gi...@apache.org> on 2026/06/22 22:55:49 UTC
Re: [PR] fix(a11y): WCAG 2.4.1 — add SkipLink component for keyboard bypass blocks [superset]
rusackas commented on PR #39240:
URL: https://github.com/apache/superset/pull/39240#issuecomment-4773875291
@Aitema-gmbh the SkipLink side looks great and thanks for addressing my earlier notes. Two things before I approve: `prettier (frontend)` is red on `SkipLink.tsx` — a `pre-commit run prettier` should sort it. And `VisuallyHidden` isn't rendered anywhere — is it meant to land here, or should it split into its own PR alongside an actual consumer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org